[issue13055] Distutils tries to handle null versions but fails

[Steve Dower]

Steve Dower  added the comment:

Distutils is now deprecated (see PEP 632) and all tagged issues are being 
closed. From now until removal, only release blocking issues will be considered 
for distutils.

If this issue does not relate to distutils, please remove the component and 
reopen it. If you believe it still requires a fix, most likely the issue should 
be re-reported at https://github.com/pypa/setuptools

--
nosy: +steve.dower
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +12129
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
components:  -Distutils2
nosy: +dstufft
versions: +Python 3.4, Python 3.5 -3rd party, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

 The bug was encountered while trying to install a package. As it turns
 out, a dependency was incorrectly installed, resulting in a null
 version being passed around which quickly caused a crash in setup.py.
 While this is definitely not a normal circumstance, the fact that this
 bug existed made finding the issue substantially more time consuming.
I agree.  You don’t happen to have the log available, do you?

 If the constructor of the LooseVersion can accept None, then so should
 its other members.
Sure.  From a quick glance, we need to fix __str__ and _cmp.

--
keywords: +easy -patch
stage: test needed - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ben Gamari]

Ben Gamari bgam...@gmail.com added the comment:

Sorry, no log is available.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

The fact that 1) StrictVersion and LooseVersion have None as default argument 
for vstring in __init__ 2) __init__ does not raise an exception if vstring is 
not given makes me think that the intended behavior is that the vstring 
argument is optional.  Making it required would be a behavior change which 
would run contrary to the distutils code freeze*.  I don’t feel that the 
workaround (set self.vstring to '') is okay; I’d rather fix the methods that 
fail when self.vstring is not defined, like __str__, or document the 
limitations.  What is your use case for these classes, and what methods need 
fixing?

* There is a lot of code out there that will break if we start to add and remove
  things, so a freeze was decided and we work on distutils2, a new version.
  distutils only gets fixes for real bugs.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ben Gamari]

Ben Gamari bgam...@gmail.com added the comment:

The bug was encountered while trying to install a package. As it turns out, a 
dependency was incorrectly installed, resulting in a null version being passed 
around which quickly caused a crash in setup.py. While this is definitely not a 
normal circumstance, the fact that this bug existed made finding the issue 
substantially more time consuming. If the constructor of the LooseVersion can 
accept None, then so should its other members.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

Thanks, will fix it.

--
assignee: tarek - eric.araujo
components: +Distutils2
nosy: +alexis
versions: +3rd party, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ben Gamari]

New submission from Ben Gamari bgam...@gmail.com:

The distutils.LooseVersion constructor currently only calls parse if vstring 
has a value. Unfortunately, this means that a user passing in vstring= or 
vstring=None gets a version object with self.vstring and self.version unset. 
This wreaks havoc later when the user tries to do anything with their object. 
I've attached two possible solutions.

The first attempts to fix the issue by raising an exception when an invalid 
vstring is given. This seems like the most reasonable treatment of this case as 
there is no reasonable way to fully initialize the object. The second works 
around the issue, initializing the uninitialized fields with  in the event of 
an invalid vstring.

--
files: distutils-fix.patch
keywords: patch
messages: 144575
nosy: bgamari
priority: normal
severity: normal
status: open
title: Distutils tries to handle null versions but fails
Added file: http://bugs.python.org/file23252/distutils-fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ben Gamari]

Changes by Ben Gamari bgam...@gmail.com:


Added file: http://bugs.python.org/file23253/distutils-workaround.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ben Gamari]

Changes by Ben Gamari bgam...@gmail.com:


--
assignee:  - tarek
components: +Distutils
nosy: +eric.araujo, tarek
type:  - crash
versions: +Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13055] Distutils tries to handle null versions but fails

[Ezio Melotti]

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
stage:  - test needed
type: crash - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com