[issue13163] `port` and `host` are confused in `_get_socket
Roundup Robot added the comment: New changeset 5d99042bd40f by R David Murray in branch '2.7': #13163: fix names of _get_socket args http://hg.python.org/cpython/rev/5d99042bd40f -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
R. David Murray added the comment: Thanks Victor. I decided not to put in the doc string because Python3 doesn't have one. -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Víctor Terrón quinta...@gmail.com added the comment: I have added a docstring to _get_socket. My proposed news entry is almost exactly what you suggested (I have just replaced 'identity' with 'identify'): Issue #13163: Fix smtplib.SMTP._get_socket so that tracebacks correctly identify host and port arguments. -- Added file: http://bugs.python.org/file23460/issue13163.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Changes by Víctor Terrón quinta...@gmail.com: Removed file: http://bugs.python.org/file23404/smtplib.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Changes by Víctor Terrón quinta...@gmail.com: Removed file: http://bugs.python.org/file23397/smtplib.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Víctor Terrón quinta...@gmail.com added the comment: Patch updated. It is now a two-line patch. How impressive :-) Anyway, I have verified that the entire test suite runs without failure. Should Misc/NEWS be updated for such a trivial modification? -- Added file: http://bugs.python.org/file23404/smtplib.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Terry J. Reedy tjre...@udel.edu added the comment: My understanding is that an undocumented internal methods has two bugs that cancel, so that correct calls work correctly -- but tracebacks do not. I think this should be fixed, especially given a working patch. Optionally add a doc string, which is how we usually (often, when someone gets around to it) do doc internal functions. Perhaps include the current comment (which I do not understand). If you, Victor, are not in the contributors file, add a one-line patch for that. Optionally (but it would certainly be good learning practice) add NEWS item. Something like Issue 13163: fix smtplib.SMTP._get_socket so that tracebacks correctly identity host and port arguments. However, this is best done when someone is ready to apply and push the patch, as frequent changes to NEWS make patches stale. -- nosy: +terry.reedy type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
vterron quinta...@gmail.com added the comment: Added a ridiculously simple patch, in case it is going to get fixed in 2.7. -- keywords: +patch nosy: +vterron Added file: http://bugs.python.org/file23397/smtplib.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
R. David Murray rdmur...@bitdance.com added the comment: Well, your patch is a little *too* simple: it doesn't change the function prototype to match :) This is a cosmetic issue rather than a bug, but it would still be nice to fix it. Or maybe a documentation issue in the sense that Python code is (usually) self documenting :) -- priority: normal - low ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Ram Rachum r...@rachum.com added the comment: The reason this bug bothered me is because I was debugging a Django app, and in the stacktrace's local variables I suddenly saw that `host` was `25`, which seemed like a bug to me and wasted me 5 minutes. So it's not a critical bug but it wasted my time. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
Víctor Terrón quinta...@gmail.com added the comment: It was strange it was *that* easy. My newbie apologies, David. Let me take a look at it -- hopefully it will be an adequate first task for a newcomer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13163] `port` and `host` are confused in `_get_socket
New submission from Ram Rachum r...@rachum.com: Look here: http://hg.python.org/cpython/file/3313ce92cef7/Lib/smtplib.py#l279 `port` and `host` are confused. I saw this is fixed on 3.2; possibly it should be fixed in the next 2.7 micro release too. -- components: Library (Lib) messages: 145442 nosy: cool-RR priority: normal severity: normal status: open title: `port` and `host` are confused in `_get_socket versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13163 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
