Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset fc3a63ed1f67 by Ezio Melotti in branch '3.2':
#13394: add more tests for the aifc module. Patch by Oleg Plakhotnyuk.
http://hg.python.org/cpython/rev/fc3a63ed1f67
New changeset 512d3ad81fb9 by Ezio Melotti in
Ezio Melotti ezio.melo...@gmail.com added the comment:
Fixed, thanks for the patches!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Converting prints to warnings on 3.2 might not be a good idea. I can probably
still apply the rest of the patch there, and change the warnings on 3.3 only.
--
___
Python tracker
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
For convenience I have uploaded the separate patch without warnings. Which
means that it will generate some output during tests run.
--
Added file: http://bugs.python.org/file24691/test_aifc_3_2.patch
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24691/test_aifc_3_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file24692/test_aifc_3_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Fourth patch goes to issue 13680
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
The last, fifth, patch goes to issue 13681
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Thanks for splitting the patch.
I tried to apply the patch to 3.2 and I have 3 comments:
1) you changed a commented-out assertEqual with an assertNotEqual, because
ULAW is lossy compression, so frames *may* not match. Does it mean that
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23934/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
The split is in progress. There will be at least two more patches.
Regarding your comments:
1) Sorry for my english :-) It is fully determined by the input. With this
particular test input the assertNotEqual will always pass. So I've removed
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Third patch goes to issue 13594
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23734/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Sounds perfectly reasonable. Here goes the first patch with pure test coverage.
--
Added file: http://bugs.python.org/file23931/test_aifc.patch
___
Python tracker rep...@bugs.python.org
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Second patch goes to issue 13589
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23931/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file23934/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
title: Patch to increase aifc lib test coverage with couple of minor fixes -
Patch to increase aifc lib test coverage
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Ezio Melotti ezio.melo...@gmail.com added the comment:
I think the patch includes too many changes. It would be better if you can
split it in two separate patches: one with the increased coverage, the other
with the bugs you found and their tests.
I can easily commit the first (assuming it
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23678/test_aifc2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
1. Test coverage increased to 95%.
2. G722 compressed files reading in aifc.py fixed (it used to use 0 bytes frame
size).
3. audioop's ulaw2lin, alaw2lin and adpcm2lin length checks fixed (width should
be used for output only, because input
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23677/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Minor style fixes
--
Added file: http://bugs.python.org/file23734/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23733/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Thanks for your review, Ezio!
Here goes new patch with all issues you've mentioned been fixed.
--
Added file: http://bugs.python.org/file23678/test_aifc2.patch
___
Python tracker
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
I've increased coverage of aifc.py by test_aifc.py:
before:
[1/1] test_aifc
lines cov% module (path)
56063% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py)
...
after:
[1/1] test_aifc
lines cov% module
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +r.david.murray
stage: - patch review
versions: +Python 3.2, Python 3.3 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
28 matches
Mail list logo
