Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d2cf730de195 by Petri Lehtinen in branch '2.7':
sqlite3: Port relevant documentation changes from 3.2
http://hg.python.org/cpython/rev/d2cf730de195
New changeset 5f492397ccb8 by Petri Lehtinen in branch '3.2':
Petri Lehtinen pe...@digip.org added the comment:
All patches applied, thanks everybody!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
Petri Lehtinen pe...@digip.org added the comment:
Both patches look good to me. The text_factory example is OK on 2.7 because the
OptimizedUnicode flag works correctly there.
--
___
Python tracker rep...@bugs.python.org
Changes by Éric Araujo mer...@netwok.org:
--
assignee: docs@python - petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
___
Éric Araujo mer...@netwok.org added the comment:
Here’s a patch for 2.7. I haven’t changed the text_factory example.
The second patch is for 3.2 and contains a few additional changes that I did in
my first patch.
--
Added file:
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file24635/sqlite-doc-tweaks-3.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 9eb77d455be1 by Petri Lehtinen in branch '3.2':
Issue #13491: Fix many errors in sqlite3 documentation
http://hg.python.org/cpython/rev/9eb77d455be1
New changeset ba5b337ecc27 by Petri Lehtinen in branch 'default':
Petri Lehtinen pe...@digip.org added the comment:
Éric: You can make a patch for 2.7 if you want to, I left the issue open.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
Éric Araujo mer...@netwok.org added the comment:
I think you can commit your patch, with our without merging execute_[12].py, as
you think best. Then you can do other patches (with or without pre-commit
review) to fix or clean up the examples.
--
Petri Lehtinen pe...@digip.org added the comment:
In the Doc/includes/sqlite3 directory there are still some scripts that
require the
createdb.py, so I didn't nuke the file.
Do these scripts (or a README file) explain about createdb.py?
No. There's no mention of createdb.py anywhere.
Éric Araujo mer...@netwok.org added the comment:
No examples included in the documentation now require createdb.py to be run.
Cool! These fixes should make it to 2.7 too; I can propose a patch if you
don’t want to backport yourself.
In the Doc/includes/sqlite3 directory there are still some
Petri Lehtinen pe...@digip.org added the comment:
Attaching an updated patch with the following changes:
- Updated to apply on current default branch
- No examples included in the documentation now require createdb.py to be run.
There were only three examples that required it, but these were
Petri Lehtinen pe...@digip.org added the comment:
Ah, and I added a working example of a custom text_factory function to
Doc/includes/sqlite3/text_factory.py, too.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
Éric Araujo mer...@netwok.org added the comment:
The updated patch looks good, I’ll commit it soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
Nebelhom nebel...@googlemail.com added the comment:
Hi,
thanks for your help and support, mate.
Unfortunately, no word about the createdb.py business (the last bullet
point on the list) and whether it should be referred to in the doc. Should
we just drop this from the adjustments?
Thanks.
Éric Araujo mer...@netwok.org added the comment:
Unfortunately, no word about the createdb.py business (the last bullet point
on the list)
and whether it should be referred to in the doc.
If you make the whitespace more standard, use the tempfile module (to remove
the os.remove line) and
Changes by Nebelhom nebel...@googlemail.com:
Added file: http://bugs.python.org/file23823/sqlite_code_update.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13491
___
Éric Araujo mer...@netwok.org added the comment:
It is very helpful that you review the docs. Some obvious fixes were made when
moving to Python 3 (print, etc.) but apparently the examples were not run.
Sphinx can let us run the code blocks in reST files as doctests, but it is
currently not
18 matches
Mail list logo
