[issue1349106] email.Generator does not separate headers with \r\n

2010-10-23 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Committed in r85811. -- resolution: - accepted stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1349106

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-21 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Updated patch that adds a missing test for BytesGenerator.flatten and fixes the bugs in it. Also added versionchanged tags to the docs for the linesep argument. I think this is ready to go in. -- stage: patch review - commit

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-21 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: Removed file: http://bugs.python.org/file19291/email_linesep.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1349106 ___

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-21 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: Removed file: http://bugs.python.org/file19318/email_linesep.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1349106 ___

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-21 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Removed some debugging cruft from the latest patch. -- Added file: http://bugs.python.org/file19319/email_linesep.patch ___ Python tracker rep...@bugs.python.org

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-20 Thread Malcolm Box
Malcolm Box malcolm@gmail.com added the comment: David: Great to see a patch for this. You're right of course, 8bit isn't binary - I meant binary. The main place this shows up is when you're using MIME not in email (e.g. on the web), where binary transport is entirely possible. This fix

[issue1349106] email.Generator does not separate headers with \r\n

2010-10-19 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Malcolm: a Content-Transfer-Encoding of 8bit may only contain \r and \n characters as part of the line ending sequence. 8bit is *not* binary; to use a CTE of binary the SMTP server must support BINARYMIME, which I don't think is all