Filip Gruszczyński grusz...@gmail.com added the comment:
Pleasure :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
___
Antoine Pitrou pit...@free.fr added the comment:
I suppose the status can be switched to closed?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
Meador Inge mead...@gmail.com added the comment:
Yup, oversight on my part. Thanks.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
Filip Gruszczyński grusz...@gmail.com added the comment:
I didn't know about `make patchcheck`, next time I will use it, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
maniram maniram maniandra...@gmail.com added the comment:
Remove the needs patch keyword since this bug has a patch.
--
nosy: +maniram.maniram
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Nick Coghlan ncogh...@gmail.com added the comment:
Explicitly spelling out __qualname__ like that makes the tests a bit too
sensitive to otherwise irrelevant details of the test layout.
I suggest using comparisons like self.assertEqual(wrapper.__qualname__,
f.__qualname__) and
Filip Gruszczyński grusz...@gmail.com added the comment:
Fixed tests.
--
Added file: http://bugs.python.org/file23912/13544_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
Meador Inge mead...@gmail.com added the comment:
On Sun, Dec 11, 2011 at 4:42 AM, Nick Coghlan rep...@bugs.python.org wrote:
Explicitly spelling out __qualname__ like that makes the tests a bit too
sensitive to otherwise irrelevant details of the test layout.
I suggest using comparisons
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 963e98f5ad31 by Meador Inge in branch 'default':
Issue #13544: Add __qualname__ to functools.WRAPPER_ASSIGNMENTS.
http://hg.python.org/cpython/rev/963e98f5ad31
--
nosy: +python-dev
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch Filip.
--
resolution: - fixed
stage: patch review - committed/rejected
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo, rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
___
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch with tests.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file23906/13544.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Meador Inge mead...@gmail.com added the comment:
Filip, with the exception of some minor whitespace problems (remember to run
'make patchcheck') and a missed testcase in 'TestWraps.test_default_update',
this looks good to me. I was just about to attach a similar patch. Here is
an updated
New submission from Nick Coghlan ncogh...@gmail.com:
functools.update_wrapper() and functools.wraps() should copy the new property
by default.
--
keywords: easy
messages: 148943
nosy: ncoghlan
priority: release blocker
severity: normal
stage: needs patch
status: open
title: Add
14 matches
Mail list logo