Matt Joiner anacro...@gmail.com added the comment:
This patch is a shoo-in, can someone review and commit this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13694
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 1c0058991740 by Giampaolo Rodola' in branch 'default':
Fix issue #13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/1c0058991740
--
nosy: +python-dev
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 4e5ddde76dbe by Giampaolo Rodola' in branch '2.7':
Fix issue #13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/4e5ddde76dbe
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a5add01e96be by Giampaolo Rodola' in branch '3.2':
Fix issue #13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/a5add01e96be
--
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Done. Sorry for the delay.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13694
Matt Joiner anacro...@gmail.com added the comment:
I should mention that this failure to set addr is unusual seeing as most socket
instances are wrapping AF_INET* domain sockets, and aren't likely to connect
without blocking. This is quite likely a reason nobody has observed it until
now.
It
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +giampaolo.rodola, josiahcarlson, stutzbach
stage: - patch review
versions: -Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13694
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I'm not sure how useful this is as addr will be set later, when connection is
established.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13694
Changes by Ross Lagerwall rosslagerw...@gmail.com:
--
nosy: +rosslagerwall
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13694
___
___
Matt Joiner anacro...@gmail.com added the comment:
I don't believe it is. dispatcher.addr is only set if the connection is
immediately established. It's set explicitly in dispatcher.__init__ if a socket
is provided that is already connected. It's *not* set after a connection
completes.
There
New submission from Matt Joiner anacro...@gmail.com:
Patch attached
--
components: Library (Lib)
files: dispatcher_connect_addr.patch
keywords: patch
messages: 150449
nosy: anacrolix
priority: normal
severity: normal
status: open
title: asynchronous connect in asyncore.dispatcher does
11 matches
Mail list logo