[issue14019] Unify tests for str.format and string.Formatter

STINNER Victor added the comment: Since nobody implemented this idea in 8 years, maybe it's time to give up and close this issue as out of date. It seeems like Nick was busy with other stuff, and nobody took this task in the meanwhile. -- ___ Pyth

[issue14019] Unify tests for str.format and string.Formatter

Terry J. Reedy added the comment: Victor: Irit is reviewing old issues to decide whether to close or not. She has to touch it somehow to mark it as reviewed. Irit: if you only change the version, others may think that you blindly updated the version. Better to say something that moves the

[issue14019] Unify tests for str.format and string.Formatter

Change by Terry J. Reedy : Removed file: https://bugs.python.org/file31453/mywork2.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14019] Unify tests for str.format and string.Formatter

Change by Terry J. Reedy : Removed file: https://bugs.python.org/file31202/mywork.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14019] Unify tests for str.format and string.Formatter

STINNER Victor added the comment: @Irit Katriel: Please avoid changing the versions field of old inactive issues. It changes artificially the last activity date of an issue and it sends an email to all people in the nosy list. There is no need to update the Version field of the +7500 open bu

[issue14019] Unify tests for str.format and string.Formatter

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.6, Python 3.3, Python 3.4 ___ Python tracker ___ _

[issue14019] Unify tests for str.format and string.Formatter

Change by Joseph Gordon : -- nosy: -josephgordon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue14019] Unify tests for str.format and string.Formatter

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue14019] Unify tests for str.format and string.Formatter

Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue14019] Unify tests for str.format and string.Formatter

STINNER Victor added the comment: This issue is no newcomer friendly, I remove the "easy" keyword. -- keywords: -easy nosy: +vstinner ___ Python tracker ___ _

[issue14019] Unify tests for str.format and string.Formatter

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue14019] Unify tests for str.format and string.Formatter

Changes by Brett Cannon : -- assignee: brett.cannon -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue14019] Unify tests for str.format and string.Formatter

moijes12 added the comment: > Note that this issue wasn't about the formatter module - it relates to the > str.format() method and the string.Formatter *class*. I would tend to agree with Nick and Eric. From what I see in the patch, the tests are for formatter module and not the string.Formatt

[issue14019] Unify tests for str.format and string.Formatter

Francisco Freire added the comment: Hi, I signed the contributor agreement. Thank you for your review comments. I did these tests about one year ago and right now I don't have much time to look at it again. I hope to do so in the next months. -- status: pending -> open ___

[issue14019] Unify tests for str.format and string.Formatter

Brett Cannon added the comment: Set to "pending" while I wait to hear back from Francisco on the review comments. -- status: open -> pending ___ Python tracker ___ _

[issue14019] Unify tests for str.format and string.Formatter

Brett Cannon added the comment: I added some review comments. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14019] Unify tests for str.format and string.Formatter

Brett Cannon added the comment: Francisco, can you sign the contributor agreement? https://www.python.org/psf/contrib/contrib-form/ -- ___ Python tracker ___ ___

[issue14019] Unify tests for str.format and string.Formatter

Eric V. Smith added the comment: The issue is about tests for str.format and string.Formatter, but in http://bugs.python.org/msg194709 and the associated patch there are tests for the formatter module to increase its coverage. I suggested on the mentorship list that we break this into two issu

[issue14019] Unify tests for str.format and string.Formatter

Nick Coghlan added the comment: Note that this issue wasn't about the formatter module - it relates to the str.format() method and the string.Formatter *class*. The formatter module is completely unrelated. -- ___ Python tracker

[issue14019] Unify tests for str.format and string.Formatter

Changes by Brett Cannon : -- assignee: -> brett.cannon nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14019] Unify tests for str.format and string.Formatter

Francisco Martín Brugué added the comment: The formatter module was deprecated in Python 3.4 and is scheduled for removal in Python 3.6. See [1] and [2]. --- [1] https://docs.python.org/3/library/formatter.html#module-formatter [2] https://docs.python.org/3/whatsnew/3.4.html#deprecated

[issue14019] Unify tests for str.format and string.Formatter

Francisco Freire added the comment: Thanks for the review. I corrected some issues in my code. Here is the new patch. -- Added file: http://bugs.python.org/file31453/mywork2.patch ___ Python tracker __

[issue14019] Unify tests for str.format and string.Formatter

Ezio Melotti added the comment: I left a review on rietveld. FWIW I think string_tests and related files should undergo a (major?) refactoring. I worked with them a few times and it's a bit of a mess with all those base classes and mixins. I also found some tests that weren't running becaus

[issue14019] Unify tests for str.format and string.Formatter

Francisco Freire added the comment: I increased the coverage of formatter module to 40%. I added a new file "test_formatter.py" including some unit tests. -- keywords: +patch nosy: +francisco.freire Added file: http://bugs.python.org/file31202/mywork.patch _

[issue14019] Unify tests for str.format and string.Formatter

Nick Coghlan added the comment: At least the first couple of those look like obsolete comments left over from the 2.x branch (we didn't do a mass renaming in the test suite, so many tests still live in their old locations). -- ___ Python tracker <

[issue14019] Unify tests for str.format and string.Formatter

Francisco Martín Brugué added the comment: I have some questions about this: 1) In Lib/test/string_tests.py it says: “Common tests shared by test_str, test_unicode, test_userstring and test_string” but a) I cannot find test_str b) string is imported and only some constants ascii_letter

[issue14019] Unify tests for str.format and string.Formatter

Éric Araujo added the comment: (ISTM that such test improvements would be beneficial to all branches, and we would also eschew merge issues if we change all branches. Other core devs sometimes object to test improvements or additions in stable branches though.) -- keywords: +easy nos

[issue14019] Unify tests for str.format and string.Formatter

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14019] Unify tests for str.format and string.Formatter

Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue14019] Unify tests for str.format and string.Formatter

Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue14019] Unify tests for str.format and string.Formatter

New submission from Nick Coghlan : A couple of issues have arisen where features were added to str.format without similarly being added to string.Formatter. This is only possible because the test cases for the two are currently almost entirely separate. A common set of tests defined as (fmt,