[issue14019] Unify tests for str.format and string.Formatter

[STINNER Victor]

STINNER Victor  added the comment:

Since nobody implemented this idea in 8 years, maybe it's time to give up and 
close this issue as out of date. It seeems like Nick was busy with other stuff, 
and nobody took this task in the meanwhile.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Victor: Irit is reviewing old issues to decide whether to close or not.  She 
has to touch it somehow to mark it as reviewed.

Irit: if you only change the version, others may think that you blindly updated 
the version.  Better to say something that moves the issue forward.  Also, only 
marking for the next version, now 3.10, would delay the possible future 
obsolescence of the version marking.  In any case, any coredev who merges would 
decide about backports.

This particular issue needs major surgery as it is two interleaved but 
unrelated discussions.  Francisco should have moved his unrelated patch to a 
new issue as Eric Smith asked.  I opened new issue 42299 and moved the revised 
patch there, with credit to Francisco and Ezio as reviewer.  I unlinked both 
from here.

To make the discussion of Nick's issue more readable, the unrelated messages 
about the unrelated patch should be unlinked.  I believe each message unlink 
would generate a separate email, as did the file unlinks.

--
versions:  -Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Terry J. Reedy]

Change by Terry J. Reedy :


Removed file: https://bugs.python.org/file31453/mywork2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Terry J. Reedy]

Change by Terry J. Reedy :


Removed file: https://bugs.python.org/file31202/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[STINNER Victor]

STINNER Victor  added the comment:

@Irit Katriel: Please avoid changing the versions field of old inactive issues. 
It changes artificially the last activity date of an issue and it sends an 
email to all people in the nosy list. There is no need to update the Version 
field of the +7500 open bugs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.6, Python 3.3, Python 
3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Joseph Gordon]

Change by Joseph Gordon :


--
nosy:  -josephgordon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[STINNER Victor]

STINNER Victor  added the comment:

This issue is no newcomer friendly, I remove the "easy" keyword.

--
keywords:  -easy
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Joseph Gordon]

Changes by Joseph Gordon :


--
nosy: +josephgordon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Changes by Brett Cannon br...@python.org:


--
assignee: brett.cannon - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[moijes12]

moijes12 added the comment:

 Note that this issue wasn't about the formatter module - it relates to the 
 str.format() method and the string.Formatter *class*.

I would tend to agree with Nick and Eric. From what I see in the patch, the 
tests are for formatter module and not the string.Formatter class.

--
nosy: +moijes12

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Brett Cannon added the comment:

Set to pending while I wait to hear back from Francisco on the review 
comments.

--
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Freire]

Francisco Freire added the comment:

Hi, I signed the contributor agreement. Thank you for your review comments. I 
did these tests about one year ago and right now I don't have much time to look 
at it again. I hope to do so in the next months.

--
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Brett Cannon added the comment:

Francisco, can you sign the contributor agreement? 
https://www.python.org/psf/contrib/contrib-form/

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Brett Cannon added the comment:

I added some review comments.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Eric V. Smith]

Eric V. Smith added the comment:

The issue is about tests for str.format and string.Formatter, but in 
http://bugs.python.org/msg194709 and the associated patch there are tests for 
the formatter module to increase its coverage.

I suggested on the mentorship list that we break this into two issues.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Nick Coghlan]

Nick Coghlan added the comment:

Note that this issue wasn't about the formatter module - it relates to the 
str.format() method and the string.Formatter *class*.

The formatter module is completely unrelated.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Brett Cannon]

Changes by Brett Cannon br...@python.org:


--
assignee:  - brett.cannon
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Martín Brugué]

Francisco Martín Brugué added the comment:

The formatter module was deprecated in Python 3.4 and is scheduled
for removal in Python 3.6. See [1] and [2].

---
[1] https://docs.python.org/3/library/formatter.html#module-formatter
[2] https://docs.python.org/3/whatsnew/3.4.html#deprecated

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Freire]

Francisco Freire added the comment:

Thanks for the review. I corrected some issues in my code. Here is the new 
patch.

--
Added file: http://bugs.python.org/file31453/mywork2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Ezio Melotti]

Ezio Melotti added the comment:

I left a review on rietveld.

FWIW I think string_tests and related files should undergo a (major?) 
refactoring.  I worked with them a few times and it's a bit of a mess with all 
those base classes and mixins.  I also found some tests that weren't running 
because they were accidentally overridden by one of the subclasses, or other 
tests that were duplicated.  This is especially true on Python 3, where bytes 
and str share a smaller subset of features.

--
nosy: +ezio.melotti
stage:  - patch review
type:  - enhancement
versions: +Python 3.4 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Freire]

Francisco Freire added the comment:

I increased the coverage of formatter module to 40%. I added a new file 
test_formatter.py including some unit tests.

--
keywords: +patch
nosy: +francisco.freire
Added file: http://bugs.python.org/file31202/mywork.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Martín Brugué]

Francisco Martín Brugué franci...@email.de added the comment:

I have some questions about this:

1) In Lib/test/string_tests.py it says:
“Common tests shared by test_str, test_unicode, test_userstring and
test_string”

but

   a) I cannot find test_str

   b) string is imported and only some constants ascii_letters
   and digits are used

   c) In test_join there is a comment “see the test in
   test.test_string.StringTest.test_join” Is that obsolete?
   (I cannot find StringTest in the test_string test)

2) Is there more tests for the build in format (in
test_buildin.BuiltinTest.test_format only the basic machinery is tested.
I would expect something like in test_format.py somewhere

3) it is true that all tests for the build in 'format' should also pass 
in 'string.Formatter().format'

Thanks in advance!

francis

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Nick Coghlan]

Nick Coghlan ncogh...@gmail.com added the comment:

At least the first couple of those look like obsolete comments left over from 
the 2.x branch (we didn't do a mass renaming in the test suite, so many tests 
still live in their old locations).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

(ISTM that such test improvements would be beneficial to all branches, and we 
would also eschew merge issues if we change all branches.  Other core devs 
sometimes object to test improvements or additions in stable branches though.)

--
keywords: +easy
nosy: +eric.araujo
versions: +Python 2.6, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Nick Coghlan]

New submission from Nick Coghlan ncogh...@gmail.com:

A couple of issues have arisen where features were added to str.format without 
similarly being added to string.Formatter.

This is only possible because the test cases for the two are currently almost 
entirely separate.

A common set of tests defined as (fmt, args, kwargs, output) tuples would help 
ensure that the implementations remained consistent in the future.

--
components: Tests
messages: 153392
nosy: ncoghlan
priority: normal
severity: normal
status: open
title: Unify tests for str.format and string.Formatter
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Eric V. Smith]

Changes by Eric V. Smith e...@trueblade.com:


--
nosy: +eric.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Francisco Martín Brugué]

Changes by Francisco Martín Brugué franci...@email.de:


--
nosy: +francismb

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14019] Unify tests for str.format and string.Formatter

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
nosy: +terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com