Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
thanks so much for your rime in reviewing and committing
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 48385618525b by Ezio Melotti in branch '2.7':
#14034: added the argparse tutorial. Patch by Tshepang Lekhonkhobe.
http://hg.python.org/cpython/rev/48385618525b
New changeset 11703cb2a2f3 by Ezio Melotti in branch
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 549aa1460811 by Ezio Melotti in branch '2.7':
#14034: adapt to Python 2 and fix indentation.
http://hg.python.org/cpython/rev/549aa1460811
New changeset d5b7be0629c0 by Ezio Melotti in branch '3.2':
#14034: fix
Ezio Melotti ezio.melo...@gmail.com added the comment:
Committed, thanks for the patch!
(Note that the example with TypeError: unorderable types: NoneType() = int()
works fine in Python 2 (by accident), and that I left it unchanged. Some error
messages are also different on Python 2, but I
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Thanks so much for your thorough attention to detail. I've addressed all your
latest comments.
--
Added file: http://bugs.python.org/file25417/argparse_howto5.patch
___
Python tracker
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
addressing the bulk of your comments
this does not address last message, where you want the lines highlighted; it
will be rather tedious; to me the code snippets are short enough, removing the
need for highlighting
--
Added
Ezio Melotti ezio.melo...@gmail.com added the comment:
Would be nice to get another review.
I left several comments on rietveld.
Overall the tutorial seems really nice and easy to follow (except a couple of
parts, noted in the comments).
I would replace all the uses of pow(x, y) with x**y
Ezio Melotti ezio.melo...@gmail.com added the comment:
A few more comments:
* in the review I mentioned highlighting specific code lines (this would be
really great given the incremental nature of the howto), but apparently that
requires a pygment 1.1 [0].
* all the output examples could use
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Would be nice to get another review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Nick Coghlan ncogh...@gmail.com added the comment:
A couple of thoughts on the draft HOWTO:
I like the verbosity example, but I'd also like to see it continue on into
introducing the action='count' alternative that allows -vv to
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
On Mon, Mar 19, 2012 at 10:34, Tshepang Lekhonkhobe tshep...@gmail.com wrote:
Nick Coghlan ncogh...@gmail.com added the comment:
A couple of thoughts on the draft HOWTO:
I like the verbosity example, but I'd also like to see it
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
After playing a bit more with this and thinking about it a bit, I do
get your point. It makes a lot of sense. I will attach a patch soon,
which will also include the count keyword. Thanks for the review.
Find attached. Note that I
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Find attached. Note that I kept some of those anti-pattern examples
you mentioned, and then later on introduced your preferred way of
doing things (using action=count and = checks instead of ==
ones).
Reason I kept those is to
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Okay, there was some bad markup on my version 2. Lemme fix.
--
Added file: http://bugs.python.org/file24938/argparse_howto2.patch
___
Python tracker rep...@bugs.python.org
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
Removed file: http://bugs.python.org/file24937/argparse_howto2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Nick Coghlan ncogh...@gmail.com added the comment:
Rather than is recommended by at least one core CPython developer I'd say
matches the way the CPython executable handles its own verbosity argument
(check the output of python --help)
Also, a better fix for the non-orderable types problem is
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Nick Coghlan ncogh...@gmail.com added the comment:
Rather than is recommended by at least one core CPython developer I'd say
matches the way the CPython executable handles its own verbosity argument
(check the output of python
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
Fixing a markup error. Sorry for the noise.
--
Added file: http://bugs.python.org/file24942/argparse_howto3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
Removed file: http://bugs.python.org/file24941/argparse_howto3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
friendly ping
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
___
Éric Araujo mer...@netwok.org added the comment:
I’m going to Rietveld to review the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Éric Araujo mer...@netwok.org added the comment:
Sorry, a burger party fell on me. I’ll make time this week.
Nick, I just read on python-dev that you had suggestions for argparse docs;
could you post the bug numbers / message IDs here or the list of suggestions?
--
nosy: +ncoghlan
Nick Coghlan ncogh...@gmail.com added the comment:
13850 (already mentioned above) is my relevant argparse docs proposal - it
turns out the other argparse issues I remembered posting were actual feature
requests rather than docs suggestions (FWIW, those are 14037 and 14039)
--
Nick Coghlan ncogh...@gmail.com added the comment:
A couple of thoughts on the draft HOWTO:
I like the verbosity example, but I'd also like to see it continue on into
introducing the action='count' alternative that allows -vv to set the
verbosity level to 2, etc.
I also find the idea of
Éric Araujo mer...@netwok.org added the comment:
You might want to coordinate with Issue 13850 a bit - they want a quick
reference table before
the first example (which would therefore mean before this howto which is
replacing the first example).
The howto discussed here would be a new
Steven Bethard steven.beth...@gmail.com added the comment:
Oh ok. Sounds good then!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
___
Steven Bethard steven.beth...@gmail.com added the comment:
I have no objections on adding a howto, and something like the attached patch
would be fine with me (though I don't have time to review it in full and trust
you to).
You might want to coordinate with Issue 13850 a bit - they want a
Éric Araujo mer...@netwok.org added the comment:
Nice. I’ll find time to review later; Steven, do you have objections on the
idea of adding an argparse howto? Do you want to review it yourself?
--
nosy: +bethard
title: first example in argparse doc is too complicated - Add argparse
28 matches
Mail list logo
