[issue14152] setup.py: Python header file dependencies

[Éric Araujo]

Changes by Éric Araujo :


--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Stefan Krah  added the comment:

??ric Araujo  wrote:
> > To answer your question: Neither of the last two revisions builds
> > in an out-of-source directory.
> My question was more whether the last known good revision did :)

That's what I meant. "last two revisions" was intended to refer to
the last two entries in the list. But I see the ambiguity.  :)

Thanks for reviewing!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 1c77eadba9dc by Stefan Krah in branch '3.2':
Issue #14152: Restore the Include/*.h dependencies for extension builds.
http://hg.python.org/cpython/rev/1c77eadba9dc

New changeset c85812b0e97d by Stefan Krah in branch 'default':
Issue #14152: Merge fix from 3.2.
http://hg.python.org/cpython/rev/c85812b0e97d

New changeset 3e2c230f4664 by Stefan Krah in branch '2.7':
Issue #14152: backport fix.
http://hg.python.org/cpython/rev/3e2c230f4664

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Éric Araujo]

Éric Araujo  added the comment:

> To answer your question: Neither of the last two revisions builds
> in an out-of-source directory.
My question was more whether the last known good revision did :)

> Here's a patch.
Tested with Python built in the top-level dir and in another dir, works in both 
cases.  Please apply, but not to security-only branches.

--
versions:  -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Changes by Stefan Krah :


--
stage:  -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Changes by Stefan Krah :


Removed file: http://bugs.python.org/file24673/arraymodule_deps.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Stefan Krah  added the comment:

Here's a patch.

--
keywords: +patch
Added file: http://bugs.python.org/file24676/issue14152.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Stefan Krah  added the comment:

Dependency support added: 1be93dd179df

Last good version (all Include/*.h): 9705ef3fdb22

Current behavior (only pyconfig.h): fa69e891edf4


To answer your question: Neither of the last two revisions builds
in an out-of-source directory.

Raising the priority to high: The missing dependencies caused a
bug report on core-mentorship that was extremely time consuming
until I finally had the revelation that the submitter did not
run `make distclean` after `hg fetch` (which would not be necessary
with the dependencies in place).

--
keywords:  -patch
priority: normal -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Éric Araujo]

Éric Araujo  added the comment:

I actually meant: when you build in any directory other that the top-level 
checkout directory.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Éric Araujo]

Éric Araujo  added the comment:

Does the 2.6 code work when you build in a subdirectory?  (I assume that’s why 
sysconfig is used instead of hard-coding, but I’ll check the VCS log when I 
have some time to be sure.)

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Stefan Krah  added the comment:

In Python2.6 all headers from Include/ were added:

   # Python header files
   headers = glob("Include/*.h") + ["pyconfig.h"]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14152] setup.py: Python header file dependencies

[Stefan Krah]

Stefan Krah  added the comment:

There is a comment in setup.py that suggests that *all* Python headers
should be added to the dependencies (?):


  # Python header files
  headers = [sysconfig.get_config_h_filename()]
  headers += glob(os.path.join(sysconfig.get_path('platinclude'), "*.h"))


Was that the intention? Because this is what I get when I add a
print statement:

['/home/stefan/pydev/cpython/pyconfig.h', 
'/home/stefan/pydev/cpython/pyconfig.h']

--
stage: patch review -> 
title: arraymodule: structmember.h dependency -> setup.py: Python header file 
dependencies

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com