[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Hard to understand the reluctancy to _allow_ for a different way to handle > accept timeouts. But this is also why I stopped contributing to core, > because it turned out to be more about lobbying than anything else. To get a change merged into Python,

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Nice necro :) Socketserver is already subclassable and overridable for so many things. Hard to understand the reluctancy to _allow_ for a different way to handle accept timeouts. But this is also why I stopped contributing to core, because it

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou: "... I'm against this change ..." Martin Panter: "... But this seems unreasonable to me. ..." I close the issue. You can use asyncio for non-blocking networking code. Or have a look at Twisted, Tornado, eventlet, etc. If you really want to

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2016-02-09 Thread Martin Panter
Martin Panter added the comment: FTR the python-dev discussion looks like it is . The argument for this change seems to be to support users monkey-patching the socket module, but not monkey-patching the select module. But this seems

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2015-01-16 Thread Martin Panter
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307 ___ ___ Python-bugs-list

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-05-14 Thread Kristján Valur Jónsson
Kristján Valur Jónsson krist...@ccpgames.com added the comment: Btw, I have found that socket.closesocket() is quite able, on Windows, to abort an ongoing accept() call. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-22 Thread Kristján Valur Jónsson
Kristján Valur Jónsson krist...@ccpgames.com added the comment: What's wrong with making functionality overridable, Antoine? By all means, let's keep the select() but allow subclasses to elect not to use it. As for the wakeup fd, there isn't such a thing. Why object on the basis of a

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-22 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: What's wrong with making functionality overridable, Antoine? By all means, let's keep the select() but allow subclasses to elect not to use it. It's making the implementation more complex for no obvious point. Using select() is not a bug in

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-15 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307 ___ ___

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-15 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: As discussed on python-dev, I'm against this change. Furthermore, removing the explicit select() call also removes the opportunity to use a wake-up fd instead of the current polling mechanism. -- nosy: +pitrou

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-14 Thread Kristján Valur Jónsson
New submission from Kristján Valur Jónsson krist...@ccpgames.com: SocketServer employs select.select to achieve timeout behaviour on accepting new requests. Unfortunately, the way this is implemented makes it tricky to bypass this behaviour for users that want to achieve timeout in a

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-14 Thread Kristján Valur Jónsson
Changes by Kristján Valur Jónsson krist...@ccpgames.com: Added file: http://bugs.python.org/file24851/75647.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307 ___

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-14 Thread Kristján Valur Jónsson
Changes by Kristján Valur Jónsson krist...@ccpgames.com: Removed file: http://bugs.python.org/file24851/75647.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307 ___

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2012-03-14 Thread Kristján Valur Jónsson
Changes by Kristján Valur Jónsson krist...@ccpgames.com: Added file: http://bugs.python.org/file24853/75647.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14307 ___