[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Stefan Behnel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Stefan Behnel added the comment: New changeset b5d3ceea48c181b3e2c6c67424317afed606bd39 by Stefan Behnel in branch 'master': bpo-14465: Add an indent() function to xml.etree.ElementTree to pretty-print XML trees (GH-15200)

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Stefan Behnel : -- pull_requests: +14929 pull_request: https://github.com/python/cpython/pull/15200 ___ Python tracker ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Stefan Behnel added the comment: The spec section that Raymond quoted makes it clear that pretty printing is not for everyone. But there are many use cases where it is 1) helpful, 2) leads to correct results, and 3) does not grow the file size excessively. Whoever wants to make use of it is

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Raymond Hettinger added the comment: FWIW, here is the relevant section of the XML specification, https://www.w3.org/TR/2008/REC-xml-20081126/#sec-white-space : """In editing XML documents, it is often convenient to use "white space" (spaces, tabs, and blank lines) to set apart the markup

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Andrew Grant : -- nosy: +Andrew Grant ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Mitar : -- nosy: +mitar ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Clayton Olney added the comment: I have a use case where the receiving application is expecting the indentation, and I need to run my code in Lambda. So, lxml is out of the question. -- nosy: +Clayton Olney ___ Python tracker

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Raymond Hettinger added the comment: A few more thoughts for consideration: * We already have a toprettyxml() tool in the minidom package. * Since whitespace is significant in XML, prettifying changes the content and meaning, so it doesn't round-trip and should only be used for debugging

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Matej Cepl : -- pull_requests: +8405 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Stefan Behnel added the comment: > Serialization of ElementTree in the stdlib is much slower than in lxml (see > issue25881). Perhaps it should be implemented in C. But it should be kept > simple for this. Should I say it? That's a first class use case for Cython. > Pretty-printing can be

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Matej Cepl : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Serhiy Storchaka added the comment: My thoughts: 1. Whitespaces are significant in XML. Pretty-printed XML is different from the original XML to an XML parser. For some applications some whitespaces around tags are not significant. But this depends on the

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Wolfgang Maier : -- nosy: +wolma ___ Python tracker ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka components: +XML nosy: +serhiy.storchaka versions: +Python 3.7 -Python 3.4 ___ Python tracker

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Alex Dzyoba : -- pull_requests: +3990 stage: -> patch review ___ Python tracker ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Change by Alex Dzyoba : -- nosy: +alexdzyoba ___ Python tracker ___ ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

STINNER Victor added the comment: For the record, at 2015-04-02, the bpo-23847 has been marked as a duplicate of this issue. -- nosy: +haypo ___ Python tracker

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by Matej Cepl mc...@redhat.com: -- nosy: +mcepl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___ Python-bugs-list mailing list

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___ Python-bugs-list

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Stefan Behnel added the comment: Just to reiterate this point, lxml.etree supports a pretty_print flag in its tostring() function and ElementTree.write(). It would thus make sense to support the same thing in ET. http://lxml.de/api.html#serialisation For completeness, the current signature

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___ Python-bugs-list

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Alex Henderson added the comment: Proposed patch copied over from duplicate issue 17372. -- keywords: +patch nosy: +alex.henderson Added file: http://bugs.python.org/file31168/issue14465.patch ___ Python tracker rep...@bugs.python.org

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Eli Bendersky added the comment: A patch exists in the duplicate #17372 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Éric Araujo mer...@netwok.org added the comment: You may be able to code it entirely in the Python part of the module (adding a new parameter to Element.write and tostring). -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by Santoso Wijaya santoso.wij...@gmail.com: -- nosy: +santa4nt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- title: add feature to prettify XML output - xml.etree.ElementTree: add feature to prettify XML output ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Changes by R. David Murray rdmur...@bitdance.com: -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___ ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Martin v. Löwis mar...@v.loewis.de added the comment: Would you like to provide a patch? -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Eli Bendersky eli...@gmail.com added the comment: Tshepang, Frankly, there are a lot of issues to solve in ElementTree (it hasn't been given love in a long time...) and such features would be low priority, as I'm not getting much help and am swamped already. As Martin said, patches can go a

[issue14465] xml.etree.ElementTree: add feature to prettify XML output

Tshepang Lekhonkhobe tshep...@gmail.com added the comment: Okay, I will try, even though C scares me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14465 ___