[issue14492] pdeps.py has_key
Georg Brandl ge...@python.org added the comment: Should be x not in y BTW to be idiomatic, not not x in y. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
Popa Claudiu pcmantic...@gmail.com added the comment: Hello. Here is the new patch. There was a few more problems: 1. in process, fp wasn't closed 2. in process, m_import.match(line) = 0 could fail if the regular expression didn't matched on that line I've included the tests, too. -- Added file: http://bugs.python.org/file25128/pdeps2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset e9b8115c5b25 by R David Murray in branch '3.2': #14492: fix some bugs in Tools/scripts/pdeps.py. http://hg.python.org/cpython/rev/e9b8115c5b25 New changeset 26a7cc129b3d by R David Murray in branch 'default': Merge #14492: fix some bugs in Tools/scripts/pdeps.py. http://hg.python.org/cpython/rev/26a7cc129b3d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
R. David Murray rdmur...@bitdance.com added the comment: Thanks, Popa. I made some style changes to the tests, but otherwise used your patch. One small note: your might want to see about setting your editor to show whitespace at the ends of lines, or use the 'make patchcheck' command to check for whitespace. Our commit hooks reject files that have lines with trailing whitespace, since it tends to clutter up diffs. -- resolution: - fixed stage: test needed - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
Changes by Popa Claudiu pcmantic...@gmail.com: -- components: +Demos and Tools versions: +Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
New submission from Popa Claudiu pcmantic...@gmail.com: Tools/pdeps.py is using has_key for a dictionary. The attached patch fixes this issue. -- files: pdeps.patch keywords: patch messages: 157471 nosy: Popa.Claudiu priority: normal severity: normal status: open title: pdeps.py has_key Added file: http://bugs.python.org/file25117/pdeps.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
Changes by R. David Murray rdmur...@bitdance.com: -- stage: - test needed type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14492] pdeps.py has_key
R. David Murray rdmur...@bitdance.com added the comment: This one is not a syntax error, so the new 'sundry' tests don't catch it. Want to write a test for this one? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14492 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
