Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 4d603d6782db by R David Murray in branch '3.2':
#14508: make gprof2html script runnable under python3
http://hg.python.org/cpython/rev/4d603d6782db
New changeset 73fba223c0a5 by R David Murray in branch 'default':
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for the patch. I don't think you ran the test though, since it didn't
pass, and there was a mistake in your patch :)
I had to change the test considerably, and only applied the test part on 3.3
since I used mock.
--
Éric Araujo mer...@netwok.org added the comment:
Should also use with statements IMO.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14508
___
Popa Claudiu pcmantic...@gmail.com added the comment:
Hello. I've attached the new version of the patch. I used with statement in
add_escapes and the test was rewritten according to David's suggestion.
--
Added file: http://bugs.python.org/file25139/gprof.patch
New submission from Popa Claudiu pcmantic...@gmail.com:
Tools/gprof2html.py uses file to open a file. Also, the opened file passed to
add_escapes was never closed. There's a test included in the patch.
--
components: Demos and Tools
files: gprof.patch
keywords: patch
messages: 157580
R. David Murray rdmur...@bitdance.com added the comment:
I'm getting 'malformed patch at line 30' when I try to apply your patch.
Also, while it's not wrong, I don't think there's much point in catching the
NameError and doing a fail. The second Exception clause is definitely wrong,
though,
