[issue14721] httplib doesn't specify content-length header for POST requests without data

Demian Brecht added the comment: Thanks for the heads up Ned. James: I've created #23539 in the event that you'd like to contribute a patch. -- ___ Python tracker ___ __

[issue14721] httplib doesn't specify content-length header for POST requests without data

Ned Deily added the comment: James, Demian: this issue has been closed for almost three years and the changes released long ago: comments made here will likely be ignored. Please open a new issue if you want them to be acted on. -- nosy: +ned.deily versions: -Python 3.5

[issue14721] httplib doesn't specify content-length header for POST requests without data

Demian Brecht added the comment: > I'm happy to produce a patch if there's any chance it would be merged. If the patch adheres to the RFC, then I see no reason why it shouldn't be merged. What makes this a little more tricky than the snippet that you included in your post though (which would i

[issue14721] httplib doesn't specify content-length header for POST requests without data

James Rutherford added the comment: The fix for this still doesn't set Content-Length to zero when body is None, but I don't see any reason why this should be the case. For example, the following snippet would work for any 'empty' body: if 'content-length' not in header_names: self._set_co

[issue14721] httplib doesn't specify content-length header for POST requests without data

Jesús Cea Avión added the comment: Too late for asking to keep the parenthesis :-). I hate to have to remember non-obvious precedence rules :-). Cognitive overhead. -- ___ Python tracker _

[issue14721] httplib doesn't specify content-length header for POST requests without data

Senthil Kumaran added the comment: This is fixed in all the branches. Thanks! -- assignee: -> orsenthil resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14721] httplib doesn't specify content-length header for POST requests without data

Roundup Robot added the comment: New changeset 57f1d13c2cd4 by Senthil Kumaran in branch '2.7': Fix Issue14721: Send Content-length: 0 for empty body () in the http.request http://hg.python.org/cpython/rev/57f1d13c2cd4 New changeset 6da1ab5f777d by Senthil Kumaran in branch '3.2': Fix Issue1472

[issue14721] httplib doesn't specify content-length header for POST requests without data

Senthil Kumaran added the comment: The rule for content-length seems, if there is a body for a request, even if the body is "" ( empty body), then you should send the Content-Length. The mistake in the Python httplib was, the set_content_length was called with this condition. if body and ('c

[issue14721] httplib doesn't specify content-length header for POST requests without data

Arve Knudsen added the comment: Yes, I agree it doesn't make much sense for HEAD AFAICT, but Chrome does it. Maybe there's a reason? -- ___ Python tracker ___ _

[issue14721] httplib doesn't specify content-length header for POST requests without data

Arve Knudsen added the comment: Here's my initial proposal for a patch against httplib, based on the 2.7 branch of cpython repository. I've included a couple of tests, which check that when content is empty, content-length is set to 0 for certain methods (POST/PUT etc) and not specified for o

[issue14721] httplib doesn't specify content-length header for POST requests without data

Jesús Cea Avión added the comment: HEAD?. It doesn't make sense in HEAD if it doesn't make sense in GET. Looking around, I found this, to mud the water a little bit more: . Not being explicit about th

[issue14721] httplib doesn't specify content-length header for POST requests without data

Arve Knudsen added the comment: Actually, when inspecting the HTTP requests sent by Chrome for the different methods (a great little Chrome app called Postman let me fire requests manually), I found that content-length would be set for most methods. I could confirm that 'content-length: 0' wo

[issue14721] httplib doesn't specify content-length header for POST requests without data

Arve Knudsen added the comment: Which HTTP methods should we auto-define content-length for? POST and PUT? I noticed that my first attempt at a patch would define content-length also for GET requests, which broke a unit test (test_ipv6host_header). -- ___

[issue14721] httplib doesn't specify content-length header for POST requests without data

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14721] httplib doesn't specify content-length header for POST requests without data

Piotr Dobrogost added the comment: > Fiddler reports that it receives the following headers for the POST request Python 3.2.3 on Windows Vista 64bit gives the same output for import http.client conn = http.client.HTTPConnection('localhost',) conn.request("POST", "/post", "", {}) conn.close

[issue14721] httplib doesn't specify content-length header for POST requests without data

Changes by Antoine Pitrou : -- nosy: +orsenthil stage: test needed -> needs patch versions: +Python 3.2, Python 3.3 ___ Python tracker ___ ___

[issue14721] httplib doesn't specify content-length header for POST requests without data

Jesús Cea Avión added the comment: Patch with test, please :-). I know it is a pain in the ass, but the result is having a higher quality python. -- ___ Python tracker ___ ___

[issue14721] httplib doesn't specify content-length header for POST requests without data

Arve Knudsen added the comment: I can look into patch and 3.x tonight I think. Should I provide a test with an eventual patch? -- ___ Python tracker ___ ___

[issue14721] httplib doesn't specify content-length header for POST requests without data

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> test needed type: -> behavior ___ Python tracker ___ ___ Python-bugs-list

[issue14721] httplib doesn't specify content-length header for POST requests without data

Jesús Cea Avión added the comment: Could you provide a patch? Does this affect 3.x too? -- nosy: +jcea ___ Python tracker ___ ___ P

[issue14721] httplib doesn't specify content-length header for POST requests without data

New submission from Arve Knudsen : httplib doesn't specify the HTTP header 'content-length' for POST requests without data. Conceptually this makes sense, considering the empty content. However, IIS (7.5) servers don't accept such requests and respond with a 411 status code. See this question