[issue14732] PEP 3121 Refactoring applied to _csv module
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 2496602a56e5 by Antoine Pitrou in branch 'default': Issue #14732: The _csv module now uses PEP 3121 module initialization. http://hg.python.org/cpython/rev/2496602a56e5 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Antoine Pitrou pit...@free.fr added the comment: Thanks for the updated patch, Robin. I have now committed it to the default branch. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Antoine Pitrou pit...@free.fr added the comment: Robin, I forgot: could you please sign and send the contrib form at http://www.python.org/psf/contrib/ ? It is not a copyright assignment, just a piece of paper that formally allows us to license your contribution for distribution with Python. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Changes by Robin Schreiber robin.schrei...@me.com: Added file: http://bugs.python.org/file25559/csv_pep3121_fix1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 90cf321615e5 by Antoine Pitrou in branch 'default': Remove Skip from the csv experts (see issue #14732). http://hg.python.org/devguide/rev/90cf321615e5 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Éric Araujo mer...@netwok.org added the comment: Skip: I used the nosy field autocomplete which is based on the experts file in the devguide; I can mark you retired in that file so that your name does not show up in autocomplete (but humans will still know that you might be contacted when all else fails, unless you prefer your name to be fully removed). -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Skip Montanaro s...@pobox.com added the comment: Skip: I used the nosy field autocomplete which is based on the experts file in the devguide; I can mark you retired in that file so that your name does not show up in autocomplete (but humans will still know that you might be contacted when all else fails, unless you prefer your name to be fully removed). Thanks. That would be great. I don't mind the occasional question, but don't want people thinking I am going to jump in feet first any time I'm made nosy on a ticket. S -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Skip Montanaro s...@pobox.com added the comment: Changes by Éric Araujo mer...@netwok.org: -- nosy: +skip.montanaro Thanks, but I'm out of the Python development business, except as it pertains to my day job... Skip -- nosy: +skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Antoine Pitrou pit...@free.fr added the comment: PyModule_AddObject steals the value's reference, so you need to INCREF it before. Besides that, I don't see any obvious bug, but perhaps Martin wants to take a look. -- nosy: +pitrou priority: normal - low stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Changes by Éric Araujo mer...@netwok.org: -- nosy: +skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
New submission from Robin Schreiber robin.schrei...@me.com: This patch presents my first try to apply the proposed Refactoring of PEP3121 to the csv module. I have identified three mutable global variables inside the module, two of which are references to PyObjects. I have wrapped all of them inside a dedicated struct, which is traversed by the gc after freeing the module. I also defined some macros, to hide functions calls that are now needed because of the newly introduced indirections. -- components: Extension Modules files: csv_pep3121.patch keywords: patch messages: 160032 nosy: Robin.Schreiber priority: normal severity: normal status: open title: PEP 3121 Refactoring applied to _csv module type: enhancement versions: Python 3.3 Added file: http://bugs.python.org/file25473/csv_pep3121.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Robin Schreiber robin.schrei...@me.com added the comment: The following script should fail before you have applied the bespoken patch: It basically checks wether one of the global PyObjects inside the csv module is being deleted after freeing the csv module. -- Added file: http://bugs.python.org/file25474/refactoring_test.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14732] PEP 3121 Refactoring applied to _csv module
Changes by Martin v. Löwis mar...@v.loewis.de: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14732 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
