R. David Murray added the comment:
Thanks, Milan. I had to fix a couple things: you had left the refactored
methods on the SMTPDServerTest, and somehow your new TestFamilyDetection class
got indented under SMTPDServerTest in the new version of the patch. (I also
had to update it to
Roundup Robot added the comment:
New changeset 1efbc86a200a by R David Murray in branch 'default':
#14758: add IPv6 support to smtpd.
http://hg.python.org/cpython/rev/1efbc86a200a
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Hmm. Looks like the IPv6 support is making the FreeBSD and and OSX buildbots
unhappy :(.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
Roundup Robot added the comment:
New changeset d8e0fca7cbe3 by R David Murray in branch 'default':
#14758: Need to specify the desired socket type in the getaddrinfo call.
http://hg.python.org/cpython/rev/d8e0fca7cbe3
--
___
Python tracker
Roundup Robot added the comment:
New changeset 9b0d58b0c712 by R David Murray in branch 'default':
#14758: Fix the fix (fix getaddrinfo in mock_socket)
http://hg.python.org/cpython/rev/9b0d58b0c712
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
OK, I think this is fixed.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
___
Milan Oberkirch added the comment:
Fixed it.
--
Added file: http://bugs.python.org/file35556/smtpd_061014.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
Milan Oberkirch added the comment:
I applied your suggestions.
--
Added file: http://bugs.python.org/file35542/smtpd_060914.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
Changes by Milan Oberkirch milan...@oberkirch.org:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
___
Python-bugs-list
R. David Murray added the comment:
When I run the modified test suite on a machine regrtest tells me that the test
modified the environment, specifically the asyncore.socket_map. Presumably
there is some missing cleanup logic.
--
___
Python
R. David Murray added the comment:
I added some review comments. Since this is a new feature, the patch also
needs a 'versionchanged' that indicates that ipv6 support was added.
--
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.3
Milan Oberkirch added the comment:
I was going to work on #3461 where IPv6-tests are missing for smtplib and
stumbled over this bug. I would be willing to work on this, since it's quiet
clear what needs to be done to me: implement what (vsergeev) suggested and
write tests (which includes
Milan Oberkirch added the comment:
The cleaning up of smtpd.socket was already implemented, so there was nothing
to do there.
What I did:
- Write two TestCases to check if the IP version is chosen depending on the
host-parameter
- Testing, that everything still works with an IPv6 address by
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
___
Python-bugs-list mailing list
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Unfortunately unit tests overwrite the original smtpd.socket module object with
test.mock_socket [1] and the latter one doesn't expose socket.getaddrinfo().
[1] http://hg.python.org/cpython/file/d937b527b76e/Lib/test/test_smtpd.py#l54
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
___
___
Python-bugs-list mailing list
R. David Murray rdmur...@bitdance.com added the comment:
Well, that should be fixed anyway (a cleanup added that restores the original
value). Then a new TestCase can test the socket stuff.
--
___
Python tracker rep...@bugs.python.org
New submission from Ivan Sergeev vserg...@gmail.com:
The SMTPServer class of the smtpd module creates a server socket with the IPv4
socket.AF_INET address family hardcoded, and this prevents it from later
binding to an IPv6 local address.
This occurs on line 282 of smtpd.py for the Python 2.7
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +giampaolo.rodola, r.david.murray
stage: - needs patch
type: behavior - enhancement
versions: -Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.4
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Agreed. The only problem I see is that unit tests rely on a mock socket object
and should be rewritten by using an actual socket.
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
I don't think it is necessary to rewrite the existing tests, just add some that
test the socket functionality.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14758
21 matches
Mail list logo
