STINNER Victor victor.stin...@gmail.com added the comment:
New changeset 98bc9e357f74 by R David Murray in branch 'default':
#14796: improve calendar test coverage.
http://hg.python.org/cpython/rev/98bc9e357f74
The following added test fails on Windows:
...
+def
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d3321c010af5 by R David Murray in branch 'default':
#14796: fix failure of new calendar test on windows.
http://hg.python.org/cpython/rev/d3321c010af5
--
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
The buildbots seem happy.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 98bc9e357f74 by R David Murray in branch 'default':
#14796: improve calendar test coverage.
http://hg.python.org/cpython/rev/98bc9e357f74
--
nosy: +python-dev
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
Thanks, Oleg.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file25632/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file25705/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file25562/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
I didn't event know that there is such a handy assertRaisesRegex context.
Many thanks for pointing this out!
--
Added file: http://bugs.python.org/file25632/test_calendar.patch
___
Python tracker
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
I've improved calendar.py test coverage a bit.
Before:
41071% calendar (.../Lib/calendar.py)
After:
41077% calendar (.../Lib/calendar.py)
--
components: Tests
files: test_calendar.patch
keywords: patch
Changes by Brett Cannon br...@python.org:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
___
Python-bugs-list
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
___
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for the patch.
There are a couple of things I'd change, which I or someone could do while
committing if you prefer, but if you'd like to tune up the patch yourself that
would be great.
The first is that I'd break up the tests
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Thanks for the review.
I'll happily tune the patch myself. Just when I have some spare time again.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
14 matches
Mail list logo