Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
___
Giampaolo Rodola' added the comment:
Previous issue should have been fixed by now.
Closing.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
Antoine Pitrou pit...@free.fr added the comment:
And there are test failures under Windows too :)
==
ERROR: test_link (test.test_stat.TestFilemode)
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 39d24533c6b7 by Giampaolo Rodola' in branch 'default':
#14807: fix BB failures on Windows - avoid to to rely too many details of the
mode string.
http://hg.python.org/cpython/rev/39d24533c6b7
--
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Let's see how it goes now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 492e6c6a01bb by Giampaolo Rodola' in branch 'default':
#14807: move undocumented tarfile.filemode() to stat.filemode(). Add
tarfile.filemode alias with deprecation warning.
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
___
Antoine Pitrou pit...@free.fr added the comment:
Buildbot failures:
http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/2540
http://www.python.org/dev/buildbot/all/builders/x86%20Tiger%203.x/builds/4572
--
status: closed - open
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 539fbd6e58f6 by Giampaolo Rodola' in branch 'default':
#14807: fix bb failure due to symlink test relying on hard-coded permissions
http://hg.python.org/cpython/rev/539fbd6e58f6
--
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks. It should now be fixed.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
New submission from Giampaolo Rodola' g.rod...@gmail.com:
As per:
http://mail.python.org/pipermail/python-ideas/2012-May/015104.html
Patch is in attachment.
--
components: Library (Lib)
files: filemode.patch
keywords: easy, patch
messages: 160621
nosy: giampaolo.rodola, terry.reedy
Antoine Pitrou pit...@free.fr added the comment:
I'm not sure filemode() is the best name for this. On the other hand, I don't
have any suggestion.
I don't understand why you're using atexit. tearDown() and addCleanup() are
your friends.
The call_safely thing also looks unwarranted.
Changes by Lars Gustäbel l...@gustaebel.de:
--
nosy: +lars.gustaebel
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
1. After careful check, I am convince that converted _filemode_table (now
private) is correct. Ditto for copied filemode function with adjusted docstring.
2. New test_stat.py is nice. I believe there is a new style of actually running
the
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Updated patch in attachment.
--
Added file: http://bugs.python.org/file25585/filemode.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Terry J. Reedy tjre...@udel.edu added the comment:
Looks good enough to me except for the alias docstring. If someone does
dir(tarfile) and help(filemode), they should get the message that it is a
deprecated alias and should not use it.
--
___
17 matches
Mail list logo
