[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Eli Bendersky added the comment: Committed all fixes in http://hg.python.org/cpython/rev/7d252dbfbee3 -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Eli Bendersky added the comment: Updated patch with fixed error messages, additional tests and some documentation. No support in SubElement yet -- Added file: http://bugs.python.org/file25741/issue14818.3.patch ___ Python tracker

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Eli Bendersky added the comment: The whole namespace issue is not very well documented in the ReST doc for ET - should open a new issue on this -- ___ Python tracker ___ __

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Eli Bendersky added the comment: Ezio, Your patch looks good, with these notes: * When raising TypeError in the Python constructor, say that 'attrib' must be a dict, otherwise it's not clear *what* must be a dict. * The 'attrib' keyword handling has to be added to SubElement too, as Markus s

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Markus added the comment: SubElement needs to handle the attrib keyword too. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Changes by Ezio Melotti : Added file: http://bugs.python.org/file25629/issue14818-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Changes by Ezio Melotti : Removed file: http://bugs.python.org/file25628/issue14818-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Ezio Melotti added the comment: Attached patch fixes Element constructor to accept 'attrib' as keyword arg. I couldn't find a way to make this work using PyArg_ParseTupleAndKeywords, so I ended up parsing the kwds by hand. While adding more tests I found out another difference with the Python

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Markus added the comment: Applied the patch, but could not verify 'it works for me' as Element lacks the attrib keyword. -- ___ Python tracker ___ _

[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

Changes by Arfrever Frehtes Taifersar Arahesis : -- title: C implementation of ElementTree causes regressions -> C implementation of ElementTree: Some functions should support keyword arguments ___ Python tracker