[issue14983] email.generator should always add newlines after closing boundaries

Dmitry Shachnev added the comment: Thank you for committing this! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: The existing tests that need to be changed to reflect the new behavior are sufficient for testing this, I think. There is small amount of backward compatibility concern here, but since it is an RFC compliance bug and it fixes a problem with verification, I de

[issue14983] email.generator should always add newlines after closing boundaries

Roundup Robot added the comment: New changeset d579866d6419 by R David Murray in branch '2.7': #14983: always add a line end after a MIME boundary marker. http://hg.python.org/cpython/rev/d579866d6419 New changeset c2538789c8cf by R David Murray in branch '3.3': #14983: always add a line end aft

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: Stephen: my post crossed yours. Yes, I agree with your logic, having re-read the spec (the trailing CR is clearly part of the boundary). But I still think the logic of the signing/validation is an invitation for running into problems like this. --

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: Heh, rather than "not conformant" I should have said that the two RFCs are in conflict, in my opinion. -- ___ Python tracker ___ _

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: Well, there are two problems here, I think (it's been a while since I looked at this): we should indeed be adding a crlf between mime boundary lines. But also the clients should technically be handling it not being there, as well as the case of extra whitesp

[issue14983] email.generator should always add newlines after closing boundaries

Stephen J. Turnbull added the comment: Following OpenPGP convention is clearly optional (or maybe a SHOULD, but the word "elect" makes it a pretty weak SHOULD). RFC 2046 is a MUST, it's not a matter of "convention". The problem is that a parser that works forward in the message will swallow t

[issue14983] email.generator should always add newlines after closing boundaries

Daniel Kahn Gillmor added the comment: I think the relevant specification for PGP/MIME-signed messages is RFC 3156: https://tools.ietf.org/html/rfc3156#page-5 in particular: Note: The accepted OpenPGP convention is for signed data to end with a sequence. Note that the sequence

[issue14983] email.generator should always add newlines after closing boundaries

Stephen J. Turnbull added the comment: Seems this hasn't been resolved. I have to disagree with David's interpretation of RFC 2046. The definition of a boundary says that it is "terminated" with a CRLF. It also clarifies that the introducing CRLF is "conceptually part" of the boundary. Thu

[issue14983] email.generator should always add newlines after closing boundaries

Dmitry Shachnev added the comment: > Hmm. So that means the verifiers are not paying attention to the MIME > RFC? > That's unfortunate. It seems that's true... -- ___ Python tracker ___

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: Hmm. So that means the verifiers are not paying attention to the MIME RFC? That's unfortunate. -- ___ Python tracker ___ __

[issue14983] email.generator should always add newlines after closing boundaries

Dmitry Shachnev added the comment: > By 'body' I actually meant the multipart part you are signing. Yes, I've understood you, and I mean the same :) The signature is created against the not-ending-with-newline string, in any case. -- ___ Python tra

[issue14983] email.generator should always add newlines after closing boundaries

R. David Murray added the comment: Sorry, I wasn't clear. By 'body' I actually meant the multipart part you are signing. I haven't looked at your script really, but I was thinking of something along the lines of make_sig(str(fullmsg.get_payload(0)).rstrip()). But like I said I didn't actua

[issue14983] email.generator should always add newlines after closing boundaries

Dmitry Shachnev added the comment: > Looking at your stackoverflow post, you might be able to fix this by doing an > rstrip on the string body before signing it. My body doesn't end with \n, so that doesn't help. If you suggest me any (easy) way to fix this on the level of my script, I will b

[issue14983] email.generator should always add newlines after closing boundaries

Changes by R. David Murray : -- title: [patch] email.generator should always add newlines after closing boundaries -> email.generator should always add newlines after closing boundaries ___ Python tracker ___