[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.10, Python 3.11 -Python 2.7, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[STINNER Victor]

Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Zackery Spytz]

Change by Zackery Spytz :


--
nosy: +ZackerySpytz
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +14963
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15242

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[STINNER Victor]

STINNER Victor  added the comment:

This issue is not newcomer friendly, I remove the easy keyword.

--
keywords:  -easy
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Igor Sobreira]

Igor Sobreira i...@igorsobreira.com added the comment:

My previous patch is incorrect, talking to voidspace on irc self._top_leve_dir 
should be reverted to it's previous value

so when discover is called the original value should be stored, then discovery 
done, and then the original restored

I'll work on this one.

He also pointed out that this bugfix should be backported to 2.7 and 3.2

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15010
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Igor Sobreira]

Igor Sobreira i...@igorsobreira.com added the comment:

Updated patch to restore previous value of ._top_level_dir on discover() done. 
And added a unit test.

--
Added file: 
http://bugs.python.org/file26458/restore_top_level_dir_to_previous_value.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15010
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[Igor Sobreira]

Igor Sobreira i...@igorsobreira.com added the comment:

Hello. I've attached a patch to cleanup self._top_level_dir in the end of 
discover(). Is that the expected behavior or I'm on the wrong track?

--
keywords: +patch
nosy: +igorsobreira
Added file: http://bugs.python.org/file26442/restore_top_level_dir.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15010
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15010] unittest: _top_level_dir is incorrectly persisted between calls to different load_test methods

[R. David Murray]

New submission from R. David Murray rdmur...@bitdance.com:

During the execution of the load tests protocol, the loader instance will set 
its _top_level_dir attribute, and this will persist if the loader is passed on 
to another load_tests method.  If that method does not specify a top_level_dir 
in a discovery call, the wrong top_level_dir may be used, and loading will fail.

You can reproduce this by having two test *packages* with a load_tests method 
that calls discover in their __init__.py, and specify both package names to the 
unittest CLI.

--
components: Library (Lib)
keywords: easy
messages: 162387
nosy: michael.foord, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: unittest: _top_level_dir is incorrectly persisted between calls to 
different load_test methods
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15010
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com