[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 1f81ea85e8e20347ec396001e5b869d36fe38398 by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-15037: Add a workaround for getkey() in curses for ncurses 5.7 and earlier. 
(GH-3826) (#4218)
https://github.com/python/cpython/commit/1f81ea85e8e20347ec396001e5b869d36fe38398


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4186

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 7e68790f3db75a893d5dd336e6201a63bc70212b by Serhiy Storchaka in 
branch 'master':
bpo-15037: Add a workaround for getkey() in curses for ncurses 5.7 and earlier. 
(#3826)
https://github.com/python/cpython/commit/7e68790f3db75a893d5dd336e6201a63bc70212b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It is easy to write a workaround for the first case (but it is not ). The 
workaround for the second case would be too complex. I prefer to skip the test. 
Unfortunately the version of ncurses is not exposed on Python level, thus the 
skipping is OS-specific.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +3810
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Seems there is the same cause of the failure of test_curses on OpenBSD.

==
ERROR: test_window_funcs (test.test_curses.TestCurses) (meth='window.getkey')
Test the methods of windows
--
Traceback (most recent call last):
  File "/home/serhiy/py/cpython3.7/Lib/test/test_curses.py", line 99, in 
test_window_funcs
meth()
ValueError: chr() arg not in range(0x11)

==
FAIL: test_unget_wch (test.test_curses.TestCurses)
--
Traceback (most recent call last):
  File "/home/serhiy/py/cpython3.7/Lib/test/test_curses.py", line 355, in 
test_unget_wch
self.assertEqual(read, ch)
AssertionError: -61 != 'é'

--

System ncurses version is 5.7.

--
nosy: +serhiy.storchaka
versions: +Python 3.6, Python 3.7 -Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Geoffrey Spear]

Geoffrey Spear added the comment:

This test still fails in Python 3.5 on Snow Leopard with the system ncurses; it 
would be nice to at least skip the test on systems with older ncurses.

--
nosy: +geoffreyspear
versions: +Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Roundup Robot]

Roundup Robot added the comment:

New changeset e587426d719f by Ned Deily in branch 'default':
Issue #15037: Use correct path to system terminfo database.
http://hg.python.org/cpython/rev/e587426d719f

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Martin v . Löwis]

Martin v. Löwis added the comment:

Why is this blocking the release? It looks like a problem that can be solved in 
a bug fix release, or else by requiring that Python 3.3 users use a recent 
ncurses release.

--
nosy: +loewis
priority: release blocker - normal

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Georg Brandl]

Georg Brandl added the comment:

Anything left to do here?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Georg Brandl]

Changes by Georg Brandl ge...@python.org:


--
priority: deferred blocker - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Ned Deily]

Ned Deily added the comment:

To be clear, I've eliminated the problem for the OS X installer builds by 
supplying newer versions of libncursesw so I wasn't planning on doing anything 
more on this issue myself.  It should be easy enough to reproduce on most 
platforms by installing ncursesw 5.7.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8282e4846e43 by Ned Deily in branch 'default':
Issue #15037: Build OS X installers with local copy of ncurses 5.9 libraries
http://hg.python.org/cpython/rev/8282e4846e43

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Ned Deily]

Ned Deily added the comment:

I've updated the OS X installers to build and link with a local copy of ncurses 
5.9 rather than older Apple-supplied ones, thus avoiding the library bug.  
test_curses now passes for them.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[STINNER Victor]

STINNER Victor added the comment:

To debug this issue, it would help to have the following information:
 - locale encoding: encoding variable
 - tested character: ch
 - character read by ncurses: read

Can someone reproducing the issue try to add: print(encoding=%s, ch=%r, 
read=%r % (encoding, ch, read)) before the error?

It may be an issue in the Python implementation of unget_wch() or get_wch().

--

 I believe the problem is due to a sign-extension bug in the ncurses library 
 unget_wch function (see link below).

Can we workaround this issue in Python? For example, use value  0xff?

--

The test should be modified to use the encoding of stdscr, not the locale 
encoding: encoding = stdscr.encoding. (In this test, both encodings should be 
the same.)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Georg Brandl]

Georg Brandl ge...@python.org added the comment:

Documentation issue, can be resolved after b2.

--
priority: release blocker - deferred blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Georg Brandl]

Georg Brandl ge...@python.org added the comment:

I agree it should be documented, probably wherever unget_wch is documented.

If there is a way to detect the ncurses version, the test should be skipped on 
 5.8 as well.

--
priority: deferred blocker - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15037] curses.unget_wch and test_curses fail when linked with ncurses 5.7 and earlier

[Ned Deily]

Ned Deily n...@acm.org added the comment:

Thanks for the testing.

Georg, haypo: I think a call should be made on what, if anything, to do about 
this prior to 3.3.0-final.  It seems that there are still OS distributions out 
there with older versions of ncurses.  Is documenting this bug sufficient?  If 
so, where?

--
priority: high - deferred blocker
title: test_curses fails with OverflowError - curses.unget_wch and test_curses 
fail when linked with ncurses 5.7 and earlier

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com