[issue15359] Sockets support for CAN_BCM

[Charles-François Natali]

Charles-François Natali added the comment:

Committed.
Brian, thanks for the patch!

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Roundup Robot]

Roundup Robot added the comment:

New changeset f714af60508d by Charles-François Natali in branch 'default':
Issue #15359: Add CAN_BCM protocol support to the socket module. Patch by Brian
http://hg.python.org/cpython/rev/f714af60508d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Charles-François Natali]

Charles-François Natali added the comment:

> I've added (some) docs and added checking of the BCM constants to the 
> test_socket module.

This version looks good to me.
I'll commit it next week (I currently don't have access to my
development machine).

> I would guess that checking each broadcast manager function provided by the 
> kernel isn't required?

No, the goal is not to test the kernel implementation. That should be
enough for now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Brian Thorne]

Brian Thorne added the comment:

I've added (some) docs and added checking of the BCM constants to the 
test_socket module.

I would guess that checking each broadcast manager function provided by the 
kernel isn't required?

--
Added file: http://bugs.python.org/file28805/bcm4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Brian Thorne]

Brian Thorne added the comment:

Thanks for the review Charles-François.
I can't make your suggested bcm_msg_fmt work - it was deadlocking on my machine!

--
Added file: http://bugs.python.org/file28756/bcm3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Brian Thorne]

Brian Thorne added the comment:

I've added a single BCM test. Any feedback on it would be good and then I'll 
add more complex ones.

Should the documentation be updated in this patch as well?

--
Added file: http://bugs.python.org/file28747/bcm2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Charles-François Natali]

Charles-François Natali added the comment:

Brian, could you add tests to Lib/test/test_socket.py (look for CANTest, you 
should be able to complete them).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Tshepang Lekhonkhobe]

Changes by Tshepang Lekhonkhobe :


--
nosy: +tshepang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Brian Thorne]

Brian Thorne  added the comment:

Once I've got more complete examples, I can update the patch to include a 
testcase.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +neologix

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15359] Sockets support for CAN_BCM

[Brian Thorne]

New submission from Brian Thorne :

In addition to CAN_RAW introduced in Python 3.3, it would be really useful to 
expose the CAN_BCM protocol. Effectively it hands off as much  to the kernel as 
possible which gives Python programs the ability to send and receive many 
periodic messages with little additional jitter or overhead.

I've attached an early stab at a patch to see if there is interest.

I'll be putting more examples of using BCM sockets at 
https://bitbucket.org/hardbyte/python-socket-examples

--
components: Library (Lib)
files: python_bcm.patch
keywords: patch
messages: 165527
nosy: Thorney, pitrou
priority: normal
severity: normal
status: open
title: Sockets support for CAN_BCM
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file26386/python_bcm.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com