[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Roundup Robot added the comment: New changeset 2b1d5caf63ca by R David Murray in branch 'default': whatsnew: filecmp.DEFAULT_IGNORES (#15442) http://hg.python.org/cpython/rev/2b1d5caf63ca -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Roundup Robot added the comment: New changeset a1efab48d8f8 by Eli Bendersky in branch 'default': Close #15442: Expand the list of default directories ignored by filecmp.dircmp and expose it as a module attribute http://hg.python.org/cpython/rev/a1efab48d8f8 -- nosy: +python-dev resolution: - fixed stage: test needed - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Éric Araujo added the comment: + .. versionadded:: 3.3 3.4* -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Eli Bendersky added the comment: What? Where did you see 3.3? It says 3.4 ;-) Thanks, fixed in 72ddb250f058 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Eli Bendersky added the comment: Attaching an alternative patch, that goes one (little) step further. Instead of repeating the ignored list all over the place (code, docstrings, ReST docs), the module exposes DEFAULT_IGNORES so everything can refer to it. Also added some tests for this feature. The patch is only vs. default (3.4), of course. -- Added file: http://bugs.python.org/file28669/eli_issue15442.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Éric Araujo added the comment: Should __pycache__ be ignored too? Sounds good. I don't know how to compile python without having to install it See the devguide http://docs.python.org/devguide -- stage: needs patch - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: -serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Eli Bendersky added the comment: I tend to agree with Éric here. moijes12, would you like to send an updated patch without the raw literals, and with added tests for the new/changed functionality? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
moijes12 added the comment: Yeah. I'm on it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Serhiy Storchaka added the comment: Should __pycache__ be ignored too? -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Eli Bendersky added the comment: moijes12, why are the added names raw ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Éric Araujo added the comment: ISTM the names should be regular names, not regular expression patterns. -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
R. David Murray added the comment: moijes12, thanks for the patch. Since this is a new feature we'll need to wait until the 3.3 RC1 repo is branched before applying it. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Changes by moijes12 moije...@gmail.com: -- nosy: +moijes12 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Changes by moijes12 moije...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file26971/15442.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
Chris Jerdonek added the comment: Hi moijes12, for instructions on compiling and submitting patches, etc., see the Python Developer's Guide (aka the devguide). You may also be interested in the Python Mentors Group: http://pythonmentors.com/ Lastly (a small point), in the future you can also type comments about your patch in the Comment text field in addition to the File Description text field. You can do this in the same Submit Changes operation that you use to choose and upload your file. -- nosy: +cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15442] Expand the list of default dirs filecmp.dircmp ignores
New submission from Eli Bendersky eli...@gmail.com: The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags']. This predates even Subversion! I suggest to freshen up this module to also ignore the dirs for SVN, Mercurial, Git and Bazaar. [this is a new feature, so no earlier than 3.4...] -- components: Library (Lib) keywords: easy messages: 166306 nosy: eli.bendersky priority: low severity: normal stage: needs patch status: open title: Expand the list of default dirs filecmp.dircmp ignores type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
