[issue15476] Index "code object" and link to code object definition

Martin Panter added the comment: Thanks for the patch Tommy. I think we can close this now. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Roundup Robot added the comment: New changeset 2e9aace7e10a by Tommy Beadle in branch '3.5': [Issue 15476] Make "code object" its own entry in the index https://hg.python.org/cpython/rev/2e9aace7e10a New changeset 8455bbc6b4f2 by Martin Panter in branch 'default': Issue #15476: Merge index

[issue15476] Index "code object" and link to code object definition

Martin Panter added the comment: Yes it seems you even fixed the problem with the definition list, which I thought was not fixable :) -- stage: needs patch -> commit review ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Tommy Beadle added the comment: Martin, thanks for the suggestion that worked. I believe this patch should have all of the issues addressed. -- Added file: http://bugs.python.org/file43298/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch

[issue15476] Index "code object" and link to code object definition

Martin Panter added the comment: Not sure why it doesn’t come up in the code review, but in diff --git a/Doc/reference/datamodel.rst b/Doc/reference/datamodel.rst index c0b4930..f34ba9f 100644 --- a/Doc/reference/datamodel.rst +++ b/Doc/reference/datamodel.rst @@ -847,8 +847,10 @@ Internal

[issue15476] Index "code object" and link to code object definition

Martin Panter added the comment: I haven’t tested, but maybe this will do what you want: .. index:: object; code, code object or .. index:: single: object; code single: code object -- ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Tommy Beadle added the comment: Using .. index:: object: code puts a 'code' entry under 'object' as well as 'object' under 'code'. That's the way it is for every other item that uses "object: XXX". So if you want a new 'code object' top-level item and keep 'object -> code', you're going

[issue15476] Index "code object" and link to code object definition

R. David Murray added the comment: There are entries for code with object as a subentry? That's not what I was talking about, I was talking about preserving the sub entries for 'code' under the 'object' main entry. -- ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Changes by Tommy Beadle : Added file: http://bugs.python.org/file43152/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Martin Panter added the comment: I left some minor review suggestions. But a more serious problem is that the change to Doc/reference/datamodel.rst breaks the formatting for me. Instead of a HTML , I get a followed by a . Unfortunately I don’t know of a way to get index entries to point to

[issue15476] Index "code object" and link to code object definition

Tommy Beadle added the comment: This restores the original code -> object items. -- Added file: http://bugs.python.org/file43137/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker

[issue15476] Index "code object" and link to code object definition

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue15476] Index "code object" and link to code object definition

R. David Murray added the comment: Since the main object of the issue is to have a canonical reference to use for linking 'code object' from elsewhere in the text, I think that can be satisfied by existing _bltin-code-objects 'ref' link as Terry suggests, even though it is a bit awkward to

[issue15476] Index "code object" and link to code object definition

Tommy Beadle added the comment: The attached patch makes it so that 'code object' is its own 'top-level' entry in the index instead of being 'code' with an 'object' sub-item. It also makes the links from the index go to the location in the documents just before the header instead of having

[issue15476] Index code object and link to code object definition

Terry J. Reedy added the comment: There is no entry for 'code object' (unlike, for instance 'class object'). There is an entry for 'code' and a subentry for 'object' with four links. The fourth link is to the short definition in the library manual: