Serhiy Storchaka added the comment:
Patches updated again.
--
Added file: http://bugs.python.org/file26838/istrue_check-3.3_3.patch
Added file: http://bugs.python.org/file26839/istrue_check-3.2_3.patch
Added file: http://bugs.python.org/file26840/istrue_check-2.7_3.patch
Roundup Robot added the comment:
New changeset ba1c48f8b571 by Antoine Pitrou in branch '2.7':
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors
correctly.
http://hg.python.org/cpython/rev/ba1c48f8b571
New changeset 56dc7b09f390 by Antoine Pitrou in branch '3.2':
Serhiy Storchaka added the comment:
Thank you Antoine.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
Patches updated to reflect Antoine's comments.
--
Added file: http://bugs.python.org/file26813/istrue_check-3.3_2.patch
Added file: http://bugs.python.org/file26814/istrue_check-3.2_2.patch
Added file:
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
___
___
Serhiy Storchaka added the comment:
I shall try to do this, but it will take a lot of time. Besides, now in the
code there are a lot of *correct* checked usage of PyObject_IsTrue without test
cases. So I'm not sure that the tests are needed here, and that they are worth
the effort.
New submission from Serhiy Storchaka:
PyObject_IsTrue can fail, but not everywhere in a code a returned value
checked. Here is a patches which add such checks.
Note, patches for all three Python versions are rather different.
--
components: Interpreter Core, Library (Lib)
files:
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26744/istrue_check-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26743/istrue_check-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
___
Antoine Pitrou added the comment:
Is it possible to add test cases for (at least some of) these issues?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15604
___
11 matches
Mail list logo