[issue15604] PyObject_IsTrue failure checks

2012-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patches updated again. -- Added file: http://bugs.python.org/file26838/istrue_check-3.3_3.patch Added file: http://bugs.python.org/file26839/istrue_check-3.2_3.patch Added file: http://bugs.python.org/file26840/istrue_check-2.7_3.patch

[issue15604] PyObject_IsTrue failure checks

2012-08-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset ba1c48f8b571 by Antoine Pitrou in branch '2.7': Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly. http://hg.python.org/cpython/rev/ba1c48f8b571 New changeset 56dc7b09f390 by Antoine Pitrou in branch '3.2':

[issue15604] PyObject_IsTrue failure checks

2012-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Antoine. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604

[issue15604] PyObject_IsTrue failure checks

2012-08-15 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604 ___ ___ Python-bugs-list mailing list

[issue15604] PyObject_IsTrue failure checks

2012-08-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patches updated to reflect Antoine's comments. -- Added file: http://bugs.python.org/file26813/istrue_check-3.3_2.patch Added file: http://bugs.python.org/file26814/istrue_check-3.2_2.patch Added file:

[issue15604] PyObject_IsTrue failure checks

2012-08-13 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604 ___ ___

[issue15604] PyObject_IsTrue failure checks

2012-08-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I shall try to do this, but it will take a lot of time. Besides, now in the code there are a lot of *correct* checked usage of PyObject_IsTrue without test cases. So I'm not sure that the tests are needed here, and that they are worth the effort.

[issue15604] PyObject_IsTrue failure checks

2012-08-09 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: PyObject_IsTrue can fail, but not everywhere in a code a returned value checked. Here is a patches which add such checks. Note, patches for all three Python versions are rather different. -- components: Interpreter Core, Library (Lib) files:

[issue15604] PyObject_IsTrue failure checks

2012-08-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26744/istrue_check-2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604 ___

[issue15604] PyObject_IsTrue failure checks

2012-08-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file26743/istrue_check-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604 ___

[issue15604] PyObject_IsTrue failure checks

2012-08-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Is it possible to add test cases for (at least some of) these issues? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15604 ___