[issue1561] py3k: test_mailbox fails on Windows
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: Applied 2nd solution as r61951 -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1561] py3k: test_mailbox fails on Windows
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: Three months later, one obvious correction: open all (text) files with the newline='\n' option. - This makes files identical between Unix and Windows version - no more os.linesep A compatibility problem: mailboxes created with python2.6 cannot be opened with 3.0 -- keywords: +patch Added file: http://bugs.python.org/file9865/mailbox.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1561] py3k: test_mailbox fails on Windows
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: Another patch, which uses newline='' instead. Tests pass. The patch is much smaller, and old files are more likely to be compatible. OTOH, messages are unicode strings with \r\n. Which one do you prefer? Added file: http://bugs.python.org/file9866/mailbox2.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1561] py3k: test_mailbox fails on Windows
Changes by Christian Heimes: -- nosy: +tiran priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1561] py3k: test_mailbox fails on Windows
Paul Moore added the comment: I believe that mailbox.py is expected to work with files opened in binary mode. A long time ago I opened a bug on th email package (http://bugs.python.org/issue586899) which turned out to be because mailbox.py required binary mode files. The conclusion was that it wouldn't be fixed (mainly because I couldn't work out a reasonable patch). I could look again, but I doubt I'll be any better able to work out what to do now... -- nosy: +pmoore __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1561] py3k: test_mailbox fails on Windows
Amaury Forgeot d'Arc added the comment: mailbox.py is expected to work with files opened in binary mode Not everywhere, unfortunately. Some files are still opened in text mode. And this makes a huge difference with py3k: one accepts bytes, the other requires strings. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1561 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
