[issue1564547] Py_signal_pipe

2007-12-10 Thread Guido van Rossum
Changes by Guido van Rossum: -- resolution: accepted - rejected superseder: - Patch for signal.set_wakeup_fd _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564547 _

[issue1564547] Py_signal_pipe

2007-12-09 Thread Gustavo J. A. M. Carneiro
Gustavo J. A. M. Carneiro added the comment: Minimal patch that just adds the pipe but does not attempt to fix anything else. Added file: http://bugs.python.org/file8898/python-signals-minimal.diff _ Tracker [EMAIL PROTECTED]

[issue1564547] Py_signal_pipe

2007-12-09 Thread Adam Olsen
Adam Olsen added the comment: The minimal patch doesn't initialize dummy_char or dummy_c. It's harmless here, but please fix it. ;) sizeof(dummy_char) will always be 1 (C defines sizeof as multiples of char.) The convention seems to be hardcoding 1 instead.

[issue1564547] Py_signal_pipe

2007-12-09 Thread Gustavo J. A. M. Carneiro
Gustavo J. A. M. Carneiro added the comment: The minimal patch doesn't initialize dummy_char or dummy_c. It's harmless here, but please fix it. ;) The variable is called 'dummy' for a reason. The value written or read is irrevelant... _ Tracker [EMAIL

[issue1564547] Py_signal_pipe

2007-12-08 Thread Guido van Rossum
Guido van Rossum added the comment: I've been told to look at this one more time. -- assignee: - gvanrossum nosy: +gvanrossum resolution: rejected - status: closed - open _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564547

[issue1564547] Py_signal_pipe

2007-12-07 Thread Gustavo J. A. M. Carneiro
Gustavo J. A. M. Carneiro added the comment: My understanding is that there are some things that the current patch does not address. Well, I don't know what those things are, so it's hard for me to address them. :-) _ Tracker [EMAIL PROTECTED]