[issue15749] cgitb prints html for text when display disabled.

[Irit Katriel]

Irit Katriel  added the comment:

cgi/cgitb are deprecated as per PEP 594, so there won't be further enhancements 
to them.

--
nosy: +iritkatriel
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Hi Rémi, 

I think @r.david.murray would need to review the PR, based on his last comment. 
 That's why I was asking whether the patch should be converted to a PR.  There 
seemed to be a conflict between this and issue 12890 and I wasn't certain which 
parts of this one were still useful.

However, having the PR may make it easier to review, so thank you for opening 
it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

Hi Cheryl, I updated and converted the path. Could you please review the PR?

--
nosy: +remi.lapeyre

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
pull_requests: +12290
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I can still recreate this issue under 3.8.  Should this patch be converted to a 
GitHub pull request?

--
nosy: +cheryl.sabella
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.2, Python 3.3, Python 
3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[R. David Murray]

Changes by R. David Murray rdmur...@bitdance.com:


--
versions: +Python 2.7, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[R. David Murray]

R. David Murray added the comment:

Issue 12890 fix is now committed.  Perhaps I should have worked with yours 
instead...but I didn't.  The test solution in that patch, calling python in a 
separate process, is conceptually simpler but will take more time to run.  I'm 
on the fence as to which one I prefer, having looked at your patch now...but 
I'm not sure that your patch cleans up properly, and that fact that that is 
difficult to figure out argues a bit for the cleaner subprocess solution.  I 
much prefer tests that run fast, though...

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0e4574595674 by R David Murray in branch '3.3':
#12890: skip tests which fail on windows until fixed or rewritten.
http://hg.python.org/cpython/rev/0e4574595674

New changeset 57a33af85407 by R David Murray in branch 'default':
merge #12890: skip tests which fail on windows until fixed or rewritten.
http://hg.python.org/cpython/rev/57a33af85407

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[Éric Araujo]

Éric Araujo added the comment:

Thanks for the report and patch.  Is this a duplicate of #12890?

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[aliles]

aliles added the comment:

Not an exact duplicate, although I should have seen that issue. Oops.

The 'display' and 'logdir' arguments are independent. Although I do appear to 
have gone a little overboard and fixed 12890 issue as well. Should I wait for 
that fix to be merged then reissue the patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15749] cgitb prints html for text when display disabled.

[aliles]

New submission from aliles:

If cgitb has been enabled to format as text but suppress the display, the 
output is formated as html. (Prefixed with p)

  gitb.enable(display=0, format='txt')
  raise ValueError('Oops!')
 pA problem occurred in a Python script.

The patch changes the prefix used when display is suppressed based on whether 
output is formatted as html or text. Includes unit tests and documentation 
updates.

--
components: Library (Lib)
files: p1345523495.diff
keywords: patch
messages: 168735
nosy: aliles, ncoghlan
priority: normal
severity: normal
status: open
title: cgitb prints html for text when display disabled.
type: behavior
versions: Python 3.2
Added file: http://bugs.python.org/file26941/p1345523495.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com