[issue15792] Fix compiler options for x64 builds on Windows
Roundup Robot added the comment: New changeset c49b8bdcb5cb by Tim Golden in branch '3.3': Issue 15792 Correct build options on Win64. Patch by Jeremy Kloth. http://hg.python.org/cpython/rev/c49b8bdcb5cb -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Tim Golden added the comment: Applied. Thanks for the patch. -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Roundup Robot added the comment: New changeset 7c46b1b239fe by Tim Golden in branch 'default': Issue 15792 Correct build options on Win64. Patch by Jeremy Kloth. http://hg.python.org/cpython/rev/7c46b1b239fe -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Tim Golden added the comment: Retargetted patch against current tip. If no-one objects I'll commit this in the next day or two. -- assignee: - tim.golden Added file: http://bugs.python.org/file32326/pcbuild.diff.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Jeremy Kloth added the comment: Just to note that, as it stands, these wrongly assigned options account for 28 of the 216 warnings (or 13%) currently emitted. This is just one easy step towards a warning-free 64-bit Windows build. It would be nice to get Win64 to be one of the warning-free platforms (see msg63893 of issue1616). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Changes by Christian Heimes li...@cheimes.de: -- components: +Windows nosy: +christian.heimes type: - compile error ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Jeremy Kloth added the comment: Adding Victor Stinner as he has been quite active in fixing Windows 64-bit issues. -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
New submission from Jeremy Kloth: The attached patch fixes the compiler options used for building the x64 platform. - In VC10 the passing /GS- as an additional option has been replaced by the MSBuild BufferSecurityCheck command - The /USECL:xxx option is only for the VSExtComp plugin for VS.NET 2003 (VC7.1) used to build a 64-bit Python 2.5 The attached patch modifies the x64 properties for VS8/9/10. -- components: Build files: pcbuild.diff keywords: patch messages: 169200 nosy: jkloth priority: normal severity: normal status: open title: Fix compiler options for x64 builds on Windows versions: Python 3.3, Python 3.4 Added file: http://bugs.python.org/file27015/pcbuild.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Changes by Georg Brandl ge...@python.org: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +brian.curtin, tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15792] Fix compiler options for x64 builds on Windows
Jeremy Kloth added the comment: I did forgot t mention that this change also silences a compiler warning: cl : Command line warning D9025: overriding '/GS' with '/GS-' The /USECL:xxx option does not provoke a warning is it is being evaluated as '/U SECL:xxx' (undefine macro) -- nosy: +jeremy.kloth ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15792 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
