[issue15826] Increased test coverage of test_glob.py

2014-08-04 Thread Ezio Melotti
Ezio Melotti added the comment: OK, I'll close the issue then. Alessandro, thanks anyway for the patch! -- resolution: -> out of date stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue15826] Increased test coverage of test_glob.py

2014-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: GlobTests.glob() tests that glob() for bytes returns the same (encoded) result as glob() for string. Therefore this patch is not needed, it doesn't increase test coverage. -- nosy: +serhiy.storchaka ___ Python tra

[issue15826] Increased test coverage of test_glob.py

2013-12-22 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: -> ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue15826] Increased test coverage of test_glob.py

2013-10-13 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: patch review -> commit review versions: -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file32106/issue15826.diff ___ Python tracker _

[issue15826] Increased test coverage of test_glob.py

2012-09-21 Thread Ezio Melotti
Ezio Melotti added the comment: FTR this is addressed in #15845. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15826] Increased test coverage of test_glob.py

2012-09-01 Thread Alessandro Moura
Alessandro Moura added the comment: Im OK with the patch changes. ''' /home/rdmurray/python/p33/Lib/os.py:263: BytesWarning: Comparison between bytes and string if tail == curdir: # xxx/newdir/. exists if xxx/newdir exists /home/rdmurray/python/p33/Lib/glob.py:63: BytesWarning: Comp

[issue15826] Increased test coverage of test_glob.py

2012-09-01 Thread R. David Murray
R. David Murray added the comment: I've modified your patch slightly (cosmetic only). When I run it on default I get the following: /home/rdmurray/python/p33/Lib/os.py:263: BytesWarning: Comparison between bytes and string if tail == curdir: # xxx/newdir/. exists if xxx/newdir exis

[issue15826] Increased test coverage of test_glob.py

2012-09-01 Thread Alessandro Moura
Alessandro Moura added the comment: test_bytes_glob_directory_with_trailing_slash already has a counterpart in the main class, but it is not easily handled by overriding self.glob and self.norm. Since it is only a single test, I just decided to override test_glob_directory_with_trailing_slash

[issue15826] Increased test coverage of test_glob.py

2012-08-31 Thread R. David Murray
R. David Murray added the comment: Is test_bytes_glob_directory_with_trailing_slash unique to bytes, or should it be added to the base class instead? What would be useful as bytes-only tests, I think, would be tests of non-ascii stuff. Although that makes me wonder, do we test non-ascii unico

[issue15826] Increased test coverage of test_glob.py

2012-08-31 Thread Alessandro Moura
Alessandro Moura added the comment: Agreed, here is the patch where this is done. -- Added file: http://bugs.python.org/file27078/test_glob.patch ___ Python tracker ___ _

[issue15826] Increased test coverage of test_glob.py

2012-08-31 Thread Ezio Melotti
Ezio Melotti added the comment: I think it would be easier to subclass GlobTests and override norm and glob there (assuming that doesn't create problems with some of the tests). -- nosy: +ezio.melotti stage: -> patch review versions: +Python 3.2, Python 3.4 ___

[issue15826] Increased test coverage of test_glob.py

2012-08-30 Thread Alessandro Moura
New submission from Alessandro Moura: Hi, Here is a patch to increase test coverage of test_glob.py. I added tests where the glob patterns are of type bytes. The coverage (according to coverage.py) is now complete, except for what are clearly artefacts probably caused by the fact that glob is