[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

miss-islington added the comment: New changeset 37a6d5f8027f969418fe53d0a73a21003a8e370d by Daniel Hahler in branch 'master': [WIP/RFC] bpo-15872: tests: remove oddity from test_rmtree_errors (GH-22967) https://github.com/python/cpython/commit/37a6d5f8027f969418fe53d0a73a21003a8e370d

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Change by daniel hahler : -- nosy: +blueyed nosy_count: 11.0 -> 12.0 pull_requests: +21883 pull_request: https://github.com/python/cpython/pull/22967 ___ Python tracker ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Roundup Robot added the comment: New changeset c9b9f786ec25 by Hynek Schlawack in branch '3.2': #15872: Add tests for a 3.3 regression in the new fd-based shutil.rmtree http://hg.python.org/cpython/rev/c9b9f786ec25 New changeset fc394216c724 by Hynek Schlawack in branch '3.3': #15872: Fix 3.3

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Roundup Robot added the comment: New changeset 5211391928bc by Hynek Schlawack in branch '3.2': #15872: Fix shutil.rmtree error tests for Windows http://hg.python.org/cpython/rev/5211391928bc New changeset 4b2fca8ad07b by Hynek Schlawack in branch '3.3': #15872: Fix shutil.rmtree error tests

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Thank you, Hynek, for review and committing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Thank you, Hynek, for review and committing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: -- Removed message: http://bugs.python.org/msg177269 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Roundup Robot added the comment: New changeset 7ce8f4a70ccd by Hynek Schlawack in branch '3.2': #15872: More shutil test fixes for Windows http://hg.python.org/cpython/rev/7ce8f4a70ccd New changeset a05e2d4094ea by Hynek Schlawack in branch '3.3': #15872: More shutil test fixes for Windows

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Roundup Robot added the comment: New changeset 2d953d47d634 by Hynek Schlawack in branch '3.2': #15872: Be flexible with appending *.* in shutil.rmtree test case http://hg.python.org/cpython/rev/2d953d47d634 New changeset edb747c6c479 by Hynek Schlawack in branch '3.3': #15872: Be flexible with

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Hynek Schlawack added the comment: “I wish I were wrangling inconsistent Windows buildbots.” Nobody. Ever. *sigh* It appears they are appeased now, so finally closing. Thanks for the patches everyone! -- resolution: - fixed stage: patch review - committed/rejected status: open -

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Roundup Robot added the comment: New changeset cb8274e1ebfa by Hynek Schlawack in branch '3.2': #15872: Some more Windows related tuning to shutil.rmtree tests http://hg.python.org/cpython/rev/cb8274e1ebfa New changeset 561c4012929a by Hynek Schlawack in branch '3.3': #15872: Some more Windows

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Patch updated. Added tests for onerror. -- Added file: http://bugs.python.org/file27840/shutil_rmtree_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Here are backported tests for 3.2 (they are passed). -- Added file: http://bugs.python.org/file27841/shutil_rmtree_tests-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Tests simplified. Thanks Hynek for review and advices. -- Added file: http://bugs.python.org/file27844/shutil_rmtree_4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file27845/shutil_rmtree_tests-3.2_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file27840/shutil_rmtree_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file27841/shutil_rmtree_tests-3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Here is a new patch. It contains some other minor changes. rmtree behavior unified for system with and without at-functions. -- stage: needs patch - patch review Added file: http://bugs.python.org/file27828/shutil_rmtree_2.patch

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Library (Lib) nosy: +larry, serhiy.storchaka versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +3.3regression ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Giampaolo Rodola' added the comment: +self.assertEqual(shutil.rmtree(os.path.join(tmpdir, tstfile), + ignore_errors=True), None) I wouldn't use assertEqual as the return value is not meaningful. -- nosy: +giampaolo.rodola

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Éric Araujo added the comment: NotADirectoryError not being caught makes sense to me: not passing a directory as argument to rmtree is a programmer error, not something coming from the OS or filesystem. -- nosy: +eric.araujo, pitrou ___ Python

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Antoine Pitrou added the comment: To be honest I don't really understand the point of the ignore_errors flag on rmtree. If rmtree fails to delete the directory tree (which will happen if one of the files can't be deleted), why would you want it to return succesfully? -- nosy: +hynek

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: Now shutil.rmtree has different behavior when called for non-directory on systems with and without at-functions. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Serhiy Storchaka added the comment: If rmtree fails to delete the directory tree (which will happen if one of the files can't be deleted), why would you want it to return succesfully? At least it free some disk space. ;-) -- ___ Python tracker

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Hynek Schlawack added the comment: To be honest I don't really understand the point of the ignore_errors flag on rmtree. If rmtree fails to delete the directory tree (which will happen if one of the files can't be deleted), why would you want it to return succesfully? I presume it’s

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___ Python-bugs-list mailing

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

New submission from Jakub Wilk: This used to work correctly in Python 3.2: Python 3.3.0rc1 (default, Aug 29 2012, 00:39:20) [GCC 4.7.1] on linux Type help, copyright, credits or license for more information. import shutil shutil.rmtree('/etc/fstab', ignore_errors=True) Traceback (most recent

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Alessandro Moura added the comment: Yes, confirmed. When checking whether the provided path is a directory, rmtree does not check whether ignore_errors is set. According to the docstring, If ignore_errors is set, errors are ignored. Presumably this means any error, in which case this is not

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Chris Jerdonek added the comment: Can you also provide a test? -- nosy: +cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___ ___

[issue15872] shutil.rmtree(..., ignore_errors=True) doesn't ignore all errors

Alessandro Moura added the comment: Added test to patch. -- Added file: http://bugs.python.org/file27139/shutil.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15872 ___