[issue15883] Add Py_errno to work around multiple CRT issue

2016-09-10 Thread Christian Heimes 

Christian Heimes added the comment:

It's no longer a problem with new VS.

--
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2014-07-14 Thread Steve Dower 

Steve Dower added the comment:

Also agreed with not exposing a side-channel to set errno.

I'd expect this to no longer be an issue with the stable CRT, but I'm not 100% 
confident about saying that yet. In theory, there will only ever be one CRT 
loaded in the future, but there's probably going to still be situations where 
explicitly providing errno is necessary.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2014-07-11 Thread Mark Lawrence 

Mark Lawrence added the comment:

Am I imagining things or have I read that the Windows CRT is going to remain 
stable in the future, meaning this work would no longer be needed.

--
components: +Windows
nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2013-12-03 Thread Christian Heimes 

Changes by Christian Heimes li...@cheimes.de:


--
status: open - pending
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2013-06-14 Thread Ronald Oussoren 

Ronald Oussoren added the comment:

I'd prefer to have new variants of the PyErr_SetFromErrno* functions where the 
errno value is explicitly passed in instead of adding a side-channel for 
passing in the value.

--
nosy: +ronaldoussoren

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2013-06-14 Thread Antoine Pitrou 

Antoine Pitrou added the comment:

Agreed with Ronald.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2012-09-14 Thread Terry J. Reedy 

Changes by Terry J. Reedy tjre...@udel.edu:


--
type: behavior - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2012-09-09 Thread Jesús Cea Avión 

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2012-09-08 Thread Christian Heimes 

New submission from Christian Heimes:

errno is usually implemented as thread local variable, more precisely as a 
macro that calls a function which returns the memory address of a thread local 
variable. Each C runtime library has its own function and TLS which introduces 
an issue when a Python extension uses a different CRT than the core. AFAIK that 
an issue only an issue on Windows with other versions of Visual Studio.

This means that mixed CRTs break the three PyErr_SetFromErrno* functions as 
they always access the errno of the core's CRT. The patch adds a Py_errno macro 
that must be used in extensions before a PyErr_SetFromErrno() function is used.

Example:
fd = open(filename, O_RDONLY);
if (fd == -1) {
Py_errno = errno;
return PyErr_SetFromErrnoWithFilename(PyExc_OSError, filename);
}

The issue was discovered by me a about two weeks ago and further analyzed by 
Martin. http://mail.python.org/pipermail/python-dev/2012-August/121460.html

--
components: Build, Extension Modules, Interpreter Core
files: pyerrno.patch
keywords: patch
messages: 170050
nosy: christian.heimes, georg.brandl, loewis, pitrou
priority: normal
severity: normal
stage: patch review
status: open
title: Add Py_errno to work around multiple CRT issue
type: behavior
versions: Python 3.3, Python 3.4
Added file: http://bugs.python.org/file27148/pyerrno.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15883] Add Py_errno to work around multiple CRT issue

2012-09-08 Thread Martin v . Löwis 

Martin v. Löwis added the comment:

Since this is a new feature, it needs to go into 3.4.

--
versions:  -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15883
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com