[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: Terry: the difference you saw between using regrtest and using unittest.main from the interactive prompt was because of regrtest.saved_test_environment: tkinter._fix sets environment variables at the beginning of one test which are cleared at the end by saved_te

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Mark Lawrence added the comment: Anything else to do here, noting the references to #21059 and #20035 ? Great work by the way, things on Windows are far cleaner than they were just a few months ago. -- nosy: +BreamoreBoy ___ Python tracker

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Terry J. Reedy added the comment: I reran external.bat in all three versions and compile runs better. Test_idle with -ugui fails to find _tkinter after another test that runs tk (including itself) *in the same process*. Adding -j2 to run in separate process eliminates the problem. F:\Python\de

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: Terry J. Reedy added the comment: > I just pulled and recompiled and got makefile error messages that I do not > remember seeing: > 13>EXEC : error : ..\..\tix-8.4.3.4 doesn't exist. This is the output of this line: > 13>C:\Program Files > (x86)\MSBuild\Micros

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Terry J. Reedy added the comment: I just pulled and recompiled and got makefile error messages that I do not remember seeing: 13>EXEC : error : ..\..\tix-8.4.3.4 doesn't exist. 13>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.MakeFile.Targets(38,5): error MSB3073: The command " 1

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

STINNER Victor added the comment: It looks like test_idlelib fails on Windows buildbots since the changeset c2e2dc6c8769b6f37638149a9e9d0aad5845b3f1: issue #21059. -- nosy: +haypo resolution: fixed -> status: closed -> open ___ Python tracker

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Roundup Robot added the comment: New changeset c12cc78d59c1 by Zachary Ware in branch 'default': Issue #15968: Temporarily revert change to PCbuild/rt.bat http://hg.python.org/cpython/rev/c12cc78d59c1 -- ___ Python tracker

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: Committed. Instead of splitting out the Tix stuff, I just disabled building Tix in Debug configuration. I will open a new issue for enabling the Debug Tix build. Thank you Martin and Tim for the votes of confidence, and Jeremy for starting this off!

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Roundup Robot added the comment: New changeset c2e2dc6c8769 by Zachary Ware in branch 'default': Issue #15968: Incorporated Tcl, Tk, and Tix builds into the Windows build http://hg.python.org/cpython/rev/c2e2dc6c8769 -- nosy: +python-dev ___ Python tr

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: If there are no objections before then, I'll split out the Tix parts of this patch and commit the rest this weekend. I'll open a new issue for adding Tix to the mix. -- ___ Python tracker

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: The problem with the previous approach and building inside Visual Studio was that makefile.vc in both Tcl and Tk first checks for one of "MSDEVDIR", "MSVCDIR", "VCINSTALLDIR", "MSSDK" or "WINDOWSSDKDIR" being set, which Visual Studio doesn't set. That issue cou

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Jeremy Kloth added the comment: I'm curious as to the issues that arose in getting 'build_tkinter.py' to work within the Visual Studio IDE, as that is what I used to develop the patches to start with. I would like to look over the new changes, but will not have any time to do so until 3-15-2014

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: Martin: I'll wait until after 3.4 is branched to commit to default, and make sure I have some time to pick up the pieces when I do :). The buildbots should be fine, though; external-common.bat is patched to pull in the tix sources as well. issue15968_tix.svndi

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Tim Golden added the comment: I haven't looked at the patch, but +1 to anything which brings Tcl/Tk/Tix support into a state of default usability. Thanks for picking this up, Zachary. -- ___ Python tracker __

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Martin v. Löwis added the comment: I wouldn't change the maintenance branches. I expect that the buildbots will break when the patch is applied, since they will fail to fetch the tix sources (unless I'm missing something). Nevertheless, I like the approach, hoping that you'll be available to f

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: I started looking at this again recently, and discovered that building from within Visual Studio doesn't work with the proposed patches. So, here's a different approach that adds 'Makefile' projects for each of Tcl, Tk, and Tix instead of using build_tkinter.py.

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Changes by Zachary Ware : -- stage: -> patch review type: -> enhancement Added file: http://bugs.python.org/file32998/issue15968_tix.svndiff ___ Python tracker ___

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: Here's a new patch based on Jeremy's that addresses all of my review comments and includes the update to Tcl/Tk 8.6.1. Also, I'll be attaching a patch to tix-8.4.3.x which allows it to be built in debug configuration and removes many warnings about unrecognized

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: I'm not sure that moving the tcltk output dir into PCbuild is the right way to go about making different versions of Tcl/Tk available to different Python versions. For one, because it's not true if you're working out of a single checkout for multiple versions.

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Zachary Ware added the comment: The current patch doesn't apply cleanly anymore and contained an accidental reversion of a commit, so I took the liberty of creating an updated version. I'll also be leaving comments on Rietveld. -- Added file: http://bugs.python.org/file30588/issue1596

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Changes by Jeremy Kloth : -- nosy: +brian.curtin, loewis, tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

Changes by Jeremy Kloth : -- keywords: +patch Added file: http://bugs.python.org/file27660/029d1cdf6422.diff ___ Python tracker ___ __

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

New submission from Jeremy Kloth: This patch incorporates Tcl/Tk/Tix into the MSVC build in the same fashion as OpenSSL has been done. Highlights: - A new project, tcltk, is added that simply calls the Python script build_tkinter.py to build the externals. - New helper module PCbuild/buildlib.