[issue16013] small csv reader bug

2012-10-20 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
resolution:  - fixed
stage: test needed - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-25 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Here is a test.

--
Added file: http://bugs.python.org/file27290/csv_eof_test.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-25 Thread Senthil Kumaran

Senthil Kumaran added the comment:

The patch looks good and is doing the right thing, that is, when the, strict 
mode is passed, it fails and without strict mode, it is printing the parsed 
list.

--
nosy: +orsenthil

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-25 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e9c005676d6e by Senthil Kumaran in branch '3.2':
Issue #16013: Fix CSV Reader parsing issue with ending quote characters. Patch 
by Serhiy Storchaka.
http://hg.python.org/cpython/rev/e9c005676d6e

New changeset 25f0756deeae by Senthil Kumaran in branch 'default':
merge 3.2: Issue #16013: Fix CSV Reader parsing issue with ending quote 
characters. Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/25f0756deeae

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-25 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 5f0465d0e91e by Senthil Kumaran in branch '2.7':
2.7 : Issue #16013: Fix CSV Reader parsing issue with ending quote characters. 
Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/5f0465d0e91e

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-24 Thread Armin Rigo

New submission from Armin Rigo:

A small bug of cvs.reader():

 list(csv.reader(['foo:'], delimiter=':', quotechar=''))
[]

Adding strict=True doesn't change anything.  This is caused by the opening 
quote not followed by anything, which causes the error to be silently ignored 
and the last line to be dropped.

--
components: Library (Lib)
messages: 171122
nosy: arigo
priority: normal
severity: normal
status: open
title: small csv reader bug
versions: Python 2.7, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-24 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

A shorter example:

 import csv
 list(csv.reader(['foo,']))
[]

--
nosy: +storchaka
type:  - behavior
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-24 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Here is a patch.

 list(csv.reader(['foo,']))
[['foo', '']]
 list(csv.reader(['foo,'], strict=1))
Traceback (most recent call last):
  File stdin, line 1, in module
_csv.Error: unexpected end of data
 list(csv.reader(['foo,^'], escapechar='^'))
[['foo', '\n']]
 list(csv.reader(['foo,^'], escapechar='^', strict=1))
Traceback (most recent call last):
  File stdin, line 1, in module
_csv.Error: unexpected end of data

Is it good?

--
keywords: +patch
Added file: http://bugs.python.org/file27283/csv_eof-3.3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-24 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


Added file: http://bugs.python.org/file27284/csv_eof-3.2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16013] small csv reader bug

2012-09-24 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
keywords: +needs review
stage:  - test needed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com