Roundup Robot added the comment:
New changeset fd786e4e331c by Berker Peksag in branch '2.7':
Issue #16056: Rename test methods to avoid conflict.
https://hg.python.org/cpython/rev/fd786e4e331c
--
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - berker.peksag
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16056
Berker Peksag added the comment:
I think my patch is wrong.
test_weak_destroy_while_iterating and
test_weak_destroy_and_mutate_while_iterating tests were committed as part of
issue 7105 to 2.7 (see changeset
https://hg.python.org/cpython/rev/03fcc12282fc). But, those same tests(they
uses
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16056
___
___
Roundup Robot added the comment:
New changeset 6d44906344f4 by Berker Peksag in branch '3.4':
Issue #16056: Rename test method in test_statistics to avoid conflict.
https://hg.python.org/cpython/rev/6d44906344f4
New changeset c49d7f4d1c04 by Berker Peksag in branch 'default':
Issue #16056:
Berker Peksag added the comment:
- issue 16079 opened for make patchcheck integration
- issue 19119 opened for test_heapq
- issue 19113 opened for test_functions
And here's a patch for 2.7.
--
nosy: +berker.peksag
stage: needs patch - patch review
versions: +Python 3.4, Python 3.5
Xavier de Gaye added the comment:
To simplify and keep the discussions more focused, etc, I would
create a new issue for the patch to patchcheck
New issue 16079 has been created.
The proposed patch in the new issue 16079 is slightly improved to
produce a cleaner output by printing the number
Xavier de Gaye added the comment:
Running find_duplicate_test_names.py (after changing the print
statements) on the 2.7 branch, gives the following output:
$ ./python find_duplicate_test_names.py Lib/test/
Duplicate test method names:
Lib/test/test_unicode.py: module.UnicodeTest.test_capitalize
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
stage: - needs patch
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16056
___
Ezio Melotti added the comment:
The script could be actually be added somewhere (e.g. Tools/scripts) and run as
part of `make patchcheck` on the test files that got changed.
--
___
Python tracker rep...@bugs.python.org
Xavier de Gaye added the comment:
The attached patch uses the infrastructure of patchcheck.py and
merges the script into patchcheck.py instead of adding a new script.
--
keywords: +patch
Added file: http://bugs.python.org/file27320/duplicate_test_names.patch
Xavier de Gaye added the comment:
patchcheck output with the patch applied:
$ make patchcheck
./python ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 1 file
Fixing whitespace ... 0 files
Fixing C file whitespace ... 0 files
Fixing docs whitespace ... 0
Roundup Robot added the comment:
New changeset e99c0425da59 by Benjamin Peterson in branch 'default':
renmae test method to avoid conflict (#16056)
http://hg.python.org/cpython/rev/e99c0425da59
--
nosy: +python-dev
___
Python tracker
Chris Jerdonek added the comment:
To simplify and keep the discussions more focused, etc, I would create a new
issue for the patch to patchcheck (and mark it enhancement). Both issues can
still reference each other.
--
___
Python tracker
New submission from Xavier de Gaye:
The attached script, named find_duplicate_test_names.py, prints
duplicate regression test method names in a given directory tree.
Running this script on the standard library test suite shows few
duplicates, see below. It means that some of those tests are not
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16056
___
___
Chris Jerdonek added the comment:
Thanks a lot for the report. Does the 2.7 branch have similar instances?
--
nosy: +ezio.melotti, michael.foord, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16056
17 matches
Mail list logo
