Gregory P. Smith added the comment:
I backported the fix to this in the subprocess32 3.2.5rc1 release I made a week
or two ago.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
Gregory P. Smith added the comment:
fyi - I agree with your comments about the test and assertRaises. This code is
old, there's a lot that could be improved in there. I chose to maintain a
style equivalent to the existing surrounding code.
Feel free to clean that up.
--
Gregory P. Smith added the comment:
replacing repr(args[0]) with repr(executable) in the identified python should
be sufficient for this bug as originally reported.
BUT it goes deeper: I just ran into this error in a different case. It also
happens when cwd is passed and the chdir(cwd)
Chris Jerdonek added the comment:
replacing repr(args[0]) with repr(executable) in the identified python should
be sufficient for this bug as originally reported.
Yes, almost. The executable variable is a bytes object so it needs to be
fsdecoded first.
I have a test and fix for that.
Roundup Robot added the comment:
New changeset e938fa6be509 by Gregory P. Smith in branch '3.2':
Fixes Issue #16114: The subprocess module no longer provides a
http://hg.python.org/cpython/rev/e938fa6be509
New changeset ee30d7ef70be by Gregory P. Smith in branch '3.3':
Fixes Issue #16114: The
Roundup Robot added the comment:
New changeset 543bb0e0afb9 by Gregory P. Smith in branch 'default':
Fixes Issue #16114: The subprocess module no longer provides a
http://hg.python.org/cpython/rev/543bb0e0afb9
--
___
Python tracker
Gregory P. Smith added the comment:
I'm keeping this open until I backport this to subprocess32 for use on Python 2.
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
Chris Jerdonek added the comment:
I made some comments on the changes as committed here:
http://mail.python.org/pipermail/python-dev/2012-October/122125.html
It would be cleaner to use the self.assertRaises() pattern here and
also probably better to share code across the three test methods
Chris Jerdonek added the comment:
Maybe better to fix Windows behavior for unifying FileNotFoundError?
I created issue 16185 to include the path in the messages of the corresponding
errors on Windows.
--
___
Python tracker rep...@bugs.python.org
Chris Jerdonek added the comment:
BTW, the patch fails for 3.2 and 3.3 but works for 3.4
By patch do you mean test? And by works, do you mean fails or succeeds?
:)
I haven't prepared a patch yet, but I just started working on it. On my
machine, I found that the test fails as is on 3.3 and
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
assignee: - chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
___
___
Andrew Svetlov added the comment:
Maybe better to fix Windows behavior for unifying FileNotFoundError?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
___
Chris Jerdonek added the comment:
I will be opening a separate issue to have the same behavior in a future
version after this issue is closed. For existing releases, we don't want to
break working code that could be relying on the difference.
--
Chris Jerdonek added the comment:
Sorry, I was confusing this issue with issue 15533. Yes, I support adding the
file path to the error message in the Windows implementation, though my
preference would be for that to be addressed as part of a separate issue.
--
Andrew Svetlov added the comment:
I'm ok with your patch if it will be applied to 3.2 etc and after that new
issue will fix Windows problem.
BTW, the patch fails for 3.2 and 3.3 but works for 3.4
--
___
Python tracker rep...@bugs.python.org
Chris Jerdonek added the comment:
Adding issue 16115 as a dependency so that the more general case can be settled
and committed before dealing with the current issue's more specific (and
platform-specific) case.
--
dependencies: +test that executable arg to Popen() takes precedence
Chris Jerdonek added the comment:
Attaching proposed tests.
--
keywords: +patch
stage: test needed - needs patch
Added file: http://bugs.python.org/file27396/issue-16114-1-tests-default.patch
___
Python tracker rep...@bugs.python.org
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
___
New submission from Chris Jerdonek:
The error message in the FileNotFoundError error raised by subprocess.Popen()
displays the wrong path when the bad path is due to the executable argument
rather than args. The message gives the path for args[0] rather than for the
executable argument.
For
Chris Jerdonek added the comment:
2.7 is not affected because 2.7 makes no attempt to display the path:
OSError: [Errno 2] No such file or directory
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16114
Chris Jerdonek added the comment:
It looks like the error is here:
if issubclass(child_exception_type, OSError) and hex_errno:
errno_num = int(hex_errno, 16)
if errno_num != 0:
err_msg = os.strerror(errno_num)
if errno_num == errno.ENOENT:
err_msg += ': ' +
21 matches
Mail list logo
