[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by Nick Coghlan : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Roundup Robot added the comment: New changeset c40b50d65a00 by Nick Coghlan in branch '3.3': Close issue #16163: handle submodules in pkgutil.iter_importers http://hg.python.org/cpython/rev/c40b50d65a00 New changeset 3bb5a8a4830e by Nick Coghlan in branch 'default': Merge fix for #16163 from 3.3

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: Is there a chance to get this into 3.3.2? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bu

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: Sorry for the delay and thanks for the suggestions Ezio and Nick. > Given the lack of proper tests for iter_importers, wouldn't adding a > proper test that returns something useful, rather than testing only > with a non-existent module be better (this test could

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Nick Coghlan added the comment: OK, I thought that iter_importers was at least being tested indirectly by the tests for walk_packages: http://hg.python.org/cpython/file/default/Lib/test/test_runpy.py#l417 However, it turns out that iter_modules() only calls iter_importers() if you don't supply

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Ezio Melotti added the comment: Given the lack of proper tests for iter_importers, wouldn't adding a proper test that returns something useful, rather than testing only with a non-existent module be better (this test could be kept, maybe converted to an assertRaises)? --

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: > I don't think it's necessary to check for UnboundLocalError/NameError > in the tests. Thanks for the review. Attached a new patch. -- Added file: http://bugs.python.org/file27885/pkgutil-name-with-test_v3.diff ___

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Ezio Melotti added the comment: I don't think it's necessary to check for UnboundLocalError/NameError in the tests. -- nosy: +ezio.melotti priority: normal -> high stage: -> patch review type: -> behavior ___ Python tracker

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by Berker Peksag : Removed file: http://bugs.python.org/file27487/pkgutil-name.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: I've attached a new patch. -- Added file: http://bugs.python.org/file27747/pkgutil-name-with-test_v2.diff ___ Python tracker ___

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Chris Jerdonek added the comment: Nick would be a better person to review the patch since IIRC he worked a bunch on that module (e.g. in the changeset you mentioned). But if I get a chance I will take a look. -- ___ Python tracker

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: Chris, did you have a chance to review the patch I submitted? The only usage of `iter_importers` function in stdlib is in `iter_modules` function: http://hg.python.org/cpython/file/cbdd6852a274/Lib/pkgutil.py#l139 -- ___

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Berker Peksag added the comment: > Can you also provide a test that fails using the current code (and > that passes with the patch applied)? New patch attached with a test. -- Added file: http://bugs.python.org/file27501/pkgutil-name-with-test.diff _

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Chris Jerdonek added the comment: Thanks for the report and patch. Can you also provide a test that fails using the current code (and that passes with the patch applied)? -- nosy: +chris.jerdonek ___ Python tracker

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

Changes by R. David Murray : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue16163] Wrong name in Lib/pkgutil.py:iter_importers

New submission from Berker Peksag: Name "pkg" is not defined. Related changeset: http://hg.python.org/cpython/rev/3987667bf98f#l2.89 -- components: Library (Lib) files: pkgutil-name.diff keywords: patch messages: 172374 nosy: berker.peksag priority: normal severity: normal status: open