[issue1617161] Instance methods compare equal when their self's are equal

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue1617161] Instance methods compare equal when their self's are equal

Serhiy Storchaka added the comment: New changeset ac20e0f98d6727ba97a9575bfa2a11b2f6247c35 by Serhiy Storchaka in branch 'master': bpo-1617161: Make the hash and equality of methods not depending on the value of self. (GH-7848) https://github.com/python/cpython/commit/ac20e0f98d6727ba97a9575

[issue1617161] Instance methods compare equal when their self's are equal

Serhiy Storchaka added the comment: PR 7848 is based on method_compare.diff and 1617161_test_update.diff, but also makes types.MethodWrapperType unorderable, adds more tests and fixes some outdated tests. This change can be considered as a bugfix, but since it can break the user code (unlik

[issue1617161] Instance methods compare equal when their self's are equal

Josh Rosenberg added the comment: If [].append == [].append is True in the "unique set of callbacks" scenario, that implies that it's perfectly fine to not call one of them when both are registered. But this means that only one list ends up getting updated, when you tried to register both fo

[issue1617161] Instance methods compare equal when their self's are equal

Change by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue1617161] Instance methods compare equal when their self's are equal

Change by Serhiy Storchaka : -- pull_requests: +7458 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue1617161] Instance methods compare equal when their self's are equal

Jeroen Demeyer added the comment: I just posted to python-dev about this issue: https://mail.python.org/pipermail/python-dev/2018-June/153959.html However, I think that comparing using "==" is the right thing to do. So I think that >>> [].append == [].append False should really return True

[issue1617161] Instance methods compare equal when their self's are equal

Armin Rigo added the comment: Sorry, I think it is pointless to spend efforts to keep a relatively uncontroversial and small patch up-to-date, when it was not accepted in 9 years. Someone else would need to take it up. -- ___ Python tracker

[issue1617161] Instance methods compare equal when their self's are equal

Serhiy Storchaka added the comment: Armin, do you mind to create a pull request on GitHub? -- type: enhancement -> behavior versions: +Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker _

[issue1617161] Instance methods compare equal when their self's are equal

Changes by Armin Rigo : -- assignee: arigo -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue1617161] Instance methods compare equal when their self's are equal

Westley Martínez added the comment: I updated the tests to be in sync, but the implementation of the fix is not so trivial. The conversion from cmp() to rich comparison is the primary culprit, so it will take time for me to get familiar enough with the C source to update the fix. I couldn't

[issue1617161] Instance methods compare equal when their self's are equal

Changes by Westley Martínez : -- nosy: +westley.martinez ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1617161] Instance methods compare equal when their self's are equal

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue1617161] Instance methods compare equal when their self's are equal

Serhiy Storchaka added the comment: Could you please update the patch for tip? I looks too desynchronized. -- stage: patch review -> needs patch ___ Python tracker ___

[issue1617161] Instance methods compare equal when their self's are equal

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-li

[issue1617161] Instance methods compare equal when their self's are equal

Changes by Terry J. Reedy : -- versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue1617161] Instance methods compare equal when their self's are equal

Alexander Belopolsky added the comment: I believe "Confirmed in trunk and py3k." means that the issue was verified to exist in trunk and py3k branches at the time of the message. -- ___ Python tracker _

[issue1617161] Instance methods compare equal when their self's are equal

Mark Lawrence added the comment: msg84597 is ambiguous. At first readng I thought it meant "the patches have been committed to trunk and py3k". Second time I think it means "yes this is still a problem". What is the status? -- nosy: +BreamoreBoy ___

[issue1617161] Instance methods compare equal when their self's are equal

Daniel Diniz added the comment: Confirmed in trunk and py3k. -- nosy: +ajaksu2 stage: -> patch review type: -> feature request versions: +Python 2.7, Python 3.1 -Python 2.5 ___ Python tracker _

[issue1617161] Instance methods compare equal when their self's are equal

Armin Rigo <[EMAIL PROTECTED]> added the comment: Attached patch for python trunk with tests. It makes all three method types use the identity of their 'self'. -- keywords: +patch Added file: http://bugs.python.org/file9666/method_compare.diff _ Track

[issue1617161] Instance methods compare equal when their self's are equal

Paul Pogonyshev <[EMAIL PROTECTED]> added the comment: Since I'm not on python-dev, I'll mention here that the new behavior makes no sense to me at all. Which is best highlighted by Frank in msg63414. -- nosy: +_doublep _ Tracker <[EMAIL PROTECTED]>

[issue1617161] Instance methods compare equal when their self's are equal

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: Armin, I think this should be discussed on python-dev. I don't understand your motivation for comparing methods of distinct but equal objects as equal. The callback argument on the other hand, is compelling. ___

[issue1617161] Instance methods compare equal when their self's are equal

Frank Niessink <[EMAIL PROTECTED]> added the comment: Just to reiterate the original bug report: the issue (for me) is that currently (python 2.5): >>> [].__add__ == [].__add__ True >>> [].__add__ == [1].__add__ False Or, using a non-builtin class: >>> class C(object): ... def __eq__(self, o

[issue1617161] Instance methods compare equal when their self's are equal

Armin Rigo <[EMAIL PROTECTED]> added the comment: My mistake, you are right. I forgot about one of the many types that CPython uses internally for built-in methods. Indeed: >>> [].index == [].index False >>> [].__add__ == [].__add__ True I can fix this so that the answer is Tr

[issue1617161] Instance methods compare equal when their self's are equal

Alexander Belopolsky added the comment: > the change was meant to unify > the behavior of built-in and > user method objects I don't think it achieved that. Consider: >>> [].index == [].index False but >>> UserList().index == UserList().index True -- nosy: +belopolsky _