[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Donald Stufft : -- pull_requests: +905 ___ Python tracker ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Roundup Robot added the comment: New changeset 96a9992d1003 by Xavier de Gaye in branch 'default': Issue #16255: subrocess.Popen uses /system/bin/sh on Android as the shell, https://hg.python.org/cpython/rev/96a9992d1003 -- nosy: +python-dev ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: For some reason the following notifications have not all been received (yet): remote: added 1 changesets with 2 changes to 2 files remote: buildbot: change(s) sent successfully remote: sent email to roundup at rep...@bugs.python.org remote:

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: New patch using sys.getandroidapilevel() that is only defined for Android. getandroidapilevel() is only available in 3.7, so only 3.7 is being fixed. -- assignee: -> xdegaye dependencies: -add function to os module for getting path to default shell

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: New patch that does not call sysconfig.get_config_var() on platforms that have '/bin/sh'. -- Added file: http://bugs.python.org/file43809/unix_shell_16255_2.patch ___ Python tracker

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Stefan Krah added the comment: Apparently sysconfig.get_config_var() is already called in site.py anyway, so in principle I'm fine with using it here. In the stdlib it seems to be the first use outside site.py though, and site.py can be disabled by using "python -S", so perhaps we should be

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Xavier de Gaye : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: The attached patch fixes the issue. There is at least already an existing test case: test_subprocess.MiscTests.test_getoutput calls subprocess.getstatusoutput() that runs a Popen instance with shell=True. -- stage: -> patch review Added file:

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: > The list of locations where '/bin/sh' is hard coded in the standard library: I have entered issue 27472. -- ___ Python tracker

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Stefan Krah added the comment: I've also opened a feature request here: https://code.google.com/p/android/issues/detail?id=210812 -- ___ Python tracker

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Xavier de Gaye added the comment: The list of locations where '/bin/sh' is hard coded in the standard library: Lib/distutils/tests/test_build_scripts.py|68 col 31| ("#!/bin/sh\n" Lib/distutils/tests/test_install_scripts.py|57 col 38| write_script("shell.sh", ("#!/bin/sh\n"

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Stefan Krah added the comment: It seems that Android is the only known platform that deviates from /bin/sh. So perhaps we should simply set a variable to either /bin/sh or /system/bin/sh rather than waiting for #16353 to settle. -- nosy: +skrah versions: +Python 3.6 -Python 3.4

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Matt Frank added the comment: Assuming issue16353 is fixed using http://bugs.python.org/file36196/os.get_shell_executable.patch the appropriate way to find the path to the default shell is by calling os.get_shell_executable(). This is the 1-liner patch that uses os.get_shell_executable() in

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Matt Frank matthew.i.fr...@intel.com: -- nosy: +WanderingLogic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Gregory P. Smith added the comment: $SHELL is up to the user and not guaranteed to be anything remotely /bin/sh compatible. On Jul 31, 2014 4:14 PM, Antoine Pitrou rep...@bugs.python.org wrote: Antoine Pitrou added the comment: Why not simply use $SHELL? -- nosy: +pitrou

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Antoine Pitrou added the comment: Why not simply use $SHELL? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- dependencies: +add function to os module for getting path to default shell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- versions: -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Chris Jerdonek added the comment: I created issue 16353 for adding a function to the os module for getting the path to the default shell. The current issue 16255 could be addressed in 3.4 by calling such a function from the subprocess module. For earlier versions (since enhancements are not

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Andrew Svetlov added the comment: Chris, agree with you. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___ Python-bugs-list mailing

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Chris Jerdonek added the comment: It occurs to me that logic for detecting the shell might make sense for being part of the os module, e.g. os.getdefaultshell(). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___ Python-bugs-list

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Andrew Svetlov added the comment: Is there some document describing procedure for building/installing/running_tests at Android device? I have Samsung Galaxy Tab and would to work on the issue. But my android experience is limited to installing Scripting Layer for Android from Google Play and

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Chris Jerdonek added the comment: It seems simple enough for us to make the default configurable This seems good to do in any case (as opposed to having the string be hard-coded), and we can test it independently of Android. There is a recently added test in the 3.x branches that can be

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Ben Rousch added the comment: Is there some document describing procedure for building/installing/running_tests at Android device? I'm using the android-python27 project, but you can also reproduce it under SL4A: Start SL4A Menu - View - Interpreters Python 2.6.2 or Python 3 from

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

New submission from Ben Rousch: The subprocess.Popen function uses /bin/sh in Unix environments. Android is detected as a Unix environemnt, but has moved that executable to /system/bin/sh. This can be worked around by adding a parameter executable='/system/bin/sh' to the call, but it is

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

R. David Murray added the comment: Android really should not be breaking the standards that way. We do want to support Android, but have you submitted a bug report to them? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Roumen Petrov added the comment: ...Applications should note that the standard PATH to the shell cannot be assumed to be either /bin/sh or /usr/bin/sh, and should be determined by interrogation of the PATH returned by getconf PATH , ensuring that the returned pathname is an absolute pathname

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Ben Rousch added the comment: @rpetrov thanks for finding that - I was having trouble hunting down what the standard is. I think you're quoting from http://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html -- ___ Python tracker

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

R. David Murray added the comment: We should do that, then, if /bin/sh doesn't exist. -- nosy: +gregory.p.smith type: crash - behavior versions: +Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +asvetlov, chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___ ___

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

Gregory P. Smith added the comment: I wouldn't blame android for this; I doubt Android claims to support whatever standard you are holding it to. It seems simple enough for us to make the default configurable (a public module level constant that anyone can override in their code after

[issue16255] subrocess.Popen needs /bin/sh but Android only has /system/bin/sh

R. David Murray added the comment: Well, posix; but I was wrong about what posix required, as Roumen pointed out. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16255 ___