[issue1628205] socket.readline() interface doesn't handle EINTR properly

Changes by Antoine Pitrou : -- resolution: -> fixed status: open -> closed versions: +Python 2.7, Python 3.1 ___ Python tracker ___ ___

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Changes by vila : -- nosy: +vila ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailm

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Jean-Paul Calderone added the comment: Backported to release26-maint in r81488. -- nosy: +exarkun ___ Python tracker ___ ___ Python

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Gregory P. Smith added the comment: fixed in trunk r74426. socket.socket.sendall() and all socket._fileobject methods (read/readline/write/flush) now properly handle EINTR internally. sendall will allow a python signal handler to raise an exception aborting it in unknown state, otherwise it ha

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Rhett Garber added the comment: Good addition Gregory. Totally agree on handling EINTR in even more cases. You can't really expect the caller to know they need to deal with this sort of thing when using these higher level call. The whole point is the abstract away some of the complexity of deali

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Gregory P. Smith added the comment: realistically, file objects (Objects/fileobject.c) never raise EINTR as they use the C library fread/fwrite/fclose underneath. Why should a socket based file object every be allowed to raise EINTR rather than handling it internally? IMHO people should onl

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Gregory P. Smith added the comment: nice test case rhettg. This is a correctness issue to prevent data loss on EINTR. I've attached a patch that builds on rhettg's but allows the EINTR signal to propagate upwards as desired by loweis and jorend for both read() and readline() calls.

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Rhett Garber added the comment: I've hit this issue as well. Attached is an updated patch to 2.6 branch and a test case. I wrote up more details here: http://nullhole.com/2009/08/02/anatomy-of-a-regression-test/ -- nosy: +rhettg Added file: http://bugs.python.org/file14634/diff ___

[issue1628205] socket.readline() interface doesn't handle EINTR properly

Changes by Daniel Diniz : -- components: +Library (Lib) stage: -> test needed type: -> behavior versions: +Python 2.6, Python 3.0 ___ Python tracker ___ _