[issue16320] Establish order in bytes/string dependencies
Roundup Robot added the comment: New changeset 8a6068ec220e by Serhiy Storchaka in branch 'default': Issue #16320: Remove redundant Makefile dependencies for strings and bytes. http://hg.python.org/cpython/rev/8a6068ec220e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Serhiy Storchaka added the comment: Fixed. Thank you for review, Meador. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Serhiy Storchaka added the comment: I'll wait for some time, perhaps a Christian wants to say something. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Serhiy Storchaka added the comment: The cleanup of BYTESTR_DEPS and UNICODE_DEPS seems reasonable, but can you explain the rationale behind removing the additional dependencies on formatter_unicode.c? This question already was asked by Antoine on IRC. Because now Python/formatter_unicode.c depends only on headers included in PYTHON_HEADERS. A special rule doesn't needed. Why were those dependencies ever needed (I can't see the dependencies from reading formatter_unicode.c and its included headers)? Perhaps this is an artifact. This dependency was added in r61057 and fce5af5ce16a by Christian Heimes. -- nosy: +christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Meador Inge added the comment: On Mon, Dec 31, 2012 at 4:50 AM, Serhiy Storchaka rep...@bugs.python.org wrote: The cleanup of BYTESTR_DEPS and UNICODE_DEPS seems reasonable, but can you explain the rationale behind removing the additional dependencies on formatter_unicode.c? This question already was asked by Antoine on IRC. OK, but not everyone is on IRC all the time. Thus the fact that it was discussed there isn't very helpful. It is better to have this type of information in the tracker so that everyone interested in the issue can have access. (preferable when opening the bug and describing what the initial patch is doing). Thanks for the extended explanation. This patch LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Meador Inge added the comment: The cleanup of BYTESTR_DEPS and UNICODE_DEPS seems reasonable, but can you explain the rationale behind removing the additional dependencies on formatter_unicode.c? Why were those dependencies ever needed (I can't see the dependencies from reading formatter_unicode.c and its included headers)? Martin explicitly added the BYTESTR_DEPS dependencies in 8beaa9a37387. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Meador Inge added the comment: Sorry, the BYTESTR_DEPS dependencies were already there pre-8beaa9a37387. I am still curious why they are needed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Changes by Meador Inge mead...@gmail.com: -- nosy: +meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Serhiy Storchaka added the comment: Please review. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
New submission from Serhiy Storchaka: The proposed patch reorganizes the dependencies for bytes and strings. Now object files depended only from needed (and from all needed) headers. This will reduce the compilation time when modifying the bytes implementation. -- components: Build, Unicode files: Makefile.pre.in.diff keywords: patch messages: 173747 nosy: ezio.melotti, haypo, serhiy.storchaka priority: normal severity: normal status: open title: Establish order in bytes/string dependencies type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file27710/Makefile.pre.in.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16320] Establish order in bytes/string dependencies
Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16320 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
