[issue16321] Move eq.h out of stringlib

[Raymond Hettinger]

Raymond Hettinger  added the comment:

The remaining unicode_eq can be left as-is.   While it is only in dictobject.c, 
the requisite knowledge of string internals makes it reasonable to keep it in 
stringlib.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
 added the comment:

To add irit's comment, It is *also* used in Objects/unicodeobject.c

--
nosy: +thatiparthy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[Irit Katriel]

Irit Katriel  added the comment:

Some of this cleanup was done but we still have unicode_eq in 
Objects/stringlib/eq.h which is only used in Objects/dictobject.c.

--
keywords: +easy (C) -patch
nosy: +iritkatriel
versions: +Python 3.11 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[moijes12]

Changes by moijes12 moije...@gmail.com:


--
nosy:  -moijes12

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[STINNER Victor]

STINNER Victor added the comment:

Issue #17628 proposes a patch which reuses unicode_eq() in 
PyUnicode_RichCompare.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[moijes12]

moijes12 added the comment:

Changes made according to the Sehiy's last comment. Include/Python.h has not 
been modified as it doesn't need one. Also, make files have been changed.

--
keywords: +patch
nosy: +moijes12
Added file: http://bugs.python.org/file29335/16321.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[STINNER Victor]

STINNER Victor added the comment:

I don't understand why do we have specialized functions to compare strings. 
Can't we reuse PyUnicode_Compare(a, b) or PyUnicode_RichCompare( a, b, Py_EQ)? 
Is unicode_eq() used to inline the code?

By the way, unicode_compare_eq() (subfunction of these functions) and 
unicode_eq() have a different implementation. unicode_eq() checks the first 
byte before calling memcmp(). We should only have one implementation, the 
fastest if possible :-)

See also issue #16286.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16321] Move eq.h out of stringlib

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

The Objects/stringlib directory used for templates which instantiates for 
specified bytes or unicode kinds. Objects/stringlib/eq.h has no relation to 
this templates and should be moved out (as Objects/unicode_eq.h for example).

Also it should be removed from Include/Python.h. It used only in 
Objects/dictobject.c and Objects/setobject.c, and included there directly.

--
components: Interpreter Core, Unicode
messages: 173749
nosy: ezio.melotti, haypo, serhiy.storchaka
priority: normal
severity: normal
stage: needs patch
status: open
title: Move eq.h out of stringlib
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com