Mike Place added the comment:
+1 to getting this patch in. The fact that this raises a ValueError and not an
ImportError is really annoying and we definitely see it as a bug.
--
nosy: +Mike Place
___
Python tracker
Jason R. Coombs added the comment:
The first thing it helps is that it eliminates a ValueError on import. Without
it, code must catch both ValueError and ImportError to run portably:
import ctypes
try:
import ctypes.wintypes
except ImportError, ValueError:
# catch ImportError and
Meador Inge added the comment:
Using 'ctypes.wintypes' on non-Windows systems is most likely a bad idea. Most
of the types are defined in terms of the types for the target that the
interpreter is built for. Comparing serializations thereof in a cross platform
manner doesn't make sense for a
Benjamin Peterson added the comment:
This is not a regression, though, so most people wouldn't be able to simplify
their code because they have to support older Python versions.
--
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
We can argue about whether it's a bugfix or not. But I don't see how having
this patch in 2.7 helps anyone, since ctypes.wintypes is useless on non-Windows
platforms.
--
___
Python tracker rep...@bugs.python.org
Amaury Forgeot d'Arc added the comment:
I think it's the opposite: when Unix support was added to ctypes, 'import
ctypes.wintypes' was not considered. By that logic, the patch is a new feature.
IMO historical arguments are moot :-)
I agree with the conclusion tough: the patch will not break
Meador Inge added the comment:
On Mon, Aug 12, 2013 at 7:11 AM, Ezio Melotti rep...@bugs.python.orgwrote:
Even if the patch is applied only on 3.4, I would still like to see the
ValueError turned into ImportError for 2.7/3.3.
Why not raise an ImportError for all versions? I don't see how
Ezio Melotti added the comment:
Even if the patch is applied only on 3.4, I would still like to see the
ValueError turned into ImportError for 2.7/3.3.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
Jason R. Coombs added the comment:
My sense on the issue is that wintypes was added to the library and was never
intended to raise a ValueError on import. By that logic, the behavior is a bug,
not a new feature. I agree with Ezio that raising a ValueError on import is a
bug. And since the
Benjamin Peterson added the comment:
Smells like a new feature to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
___
Christian Heimes added the comment:
RM, please decide. :)
--
assignee: - benjamin.peterson
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
Changes by Jason R. Coombs jar...@jaraco.com:
--
nosy: +jason.coombs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
___
Python-bugs-list
Christian Heimes added the comment:
The fix is trivial:
- define VARIANT_FALSE and VARIANT_BOOL according to specs
- enable 'v' on non-Windows systems
- enable tests for vbool
Done
--
keywords: +patch
nosy: +christian.heimes
Added file:
Jason R. Coombs added the comment:
Looks good to me. Ben, any objections to applying this to 2.7?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
Ezio Melotti added the comment:
That patch is more a workaround than an actual fix. Lib/ctypes/wintypes.py
should either fail with an ImportError or be importable. For the former it's
possible to catch the ValueError and turn it into an ImportError, or perhaps
raise it if some precondition
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
stage: - needs patch
type: - behavior
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
Dmi Baranov added the comment:
Found only this patch [1] :) I think is possible to change
VARIANT_BOOL._type_ to any of short types [2] for non-nt platforms?
[1]
https://code.launchpad.net/~mandel/python-distutils-extra/import_issues/+merge/53519
[2]
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
New submission from anatoly techtonik:
import ctypes.wintypes
Traceback (most recent call last):
File stdin, line 1, in module
File /usr/lib/python3.2/ctypes/wintypes.py, line 20, in module
class VARIANT_BOOL(ctypes._SimpleCData):
ValueError: _type_ 'v' not supported
Shouldn't it
anatoly techtonik added the comment:
Perhaps the patch already there - see http://www.themacaque.com/?p=826
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
20 matches
Mail list logo