[issue16485] FD leaks in aifc module

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : -- resolution: works for me -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : -- resolution: -> works for me stage: patch review -> committed/rejected status: open -> closed versions: +Python 2.7 ___ Python tracker ___ __

[issue16485] FD leaks in aifc module

Roundup Robot added the comment: New changeset cf8d692cc847 by Serhiy Storchaka in branch '2.7': Issue #16485: Fix file descriptor not being closed if file header patching fails on closing of aifc file. http://hg.python.org/cpython/rev/cf8d692cc847 New changeset e3c4e9f4ea0f by Serhiy Storchaka

[issue16485] FD leaks in aifc module

Serhiy Storchaka added the comment: Of course. Thanks for point. It's my editor made wrong whitespace changes after block indent/unindent. "hg diff" shows this changes and I shouldn't miss this. I will review every patch before commit one more time. --

[issue16485] FD leaks in aifc module

Georg Brandl added the comment: Looks good to me, except: the patch contains unrelated whitespace changes. Please don't commit them along the fix. If you think they are really necessary, they should go in a separate commit. -- nosy: +georg.brandl

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16485] FD leaks in aifc module

Serhiy Storchaka added the comment: If no one objects I will commit this next year. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue16485] FD leaks in aifc module

Serhiy Storchaka added the comment: > Adding "with" support to Aifc_write looks like a new feature, but Aifc_write > doesn't seem to be part of the public API. Does this change (indirectly) add > "with" support to any part of the public API? Don't pay attention, it was a wrong patch. For "wi

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file27997/aifc_close.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue16485] FD leaks in aifc module

Serhiy Storchaka added the comment: Sorry, I miss that test_close() already exists. Merged. -- Added file: http://bugs.python.org/file27999/aifc_close.patch Added file: http://bugs.python.org/file28000/aifc_close-2.7.patch ___ Python tracker

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file27998/aifc_close-2.7.patch ___ Python tracker ___ ___ Python-bugs-list

[issue16485] FD leaks in aifc module

Ezio Melotti added the comment: Adding "with" support to Aifc_write looks like a new feature, but Aifc_write doesn't seem to be part of the public API. Does this change (indirectly) add "with" support to any part of the public API? -- nosy: +ezio.melotti stage: -> patch review _

[issue16485] FD leaks in aifc module

Ezio Melotti added the comment: Adding "with" support to Aifc_write looks like a new feature, but Aifc_write doesn't seem to be part of the public API. Does this change (indirectly) add "with" support to any part of the public API? -- nosy: +ezio.melotti stage: -> patch review _

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file27998/aifc_close-2.7.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : -- nosy: +r.david.murray Added file: http://bugs.python.org/file27997/aifc_close.patch ___ Python tracker ___ __

[issue16485] FD leaks in aifc module

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file27996/aifc_close.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue16485] FD leaks in aifc module

New submission from Serhiy Storchaka: Aifc_write.close() can raise exception and left the internal file object not closed. The patch closes the file object even in case of error and reset _file to None even in case of the file object close() raises an exception, so that Aifc_write.close() can