[issue16486] Add context manager support to aifc module

2013-01-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16486] Add context manager support to aifc module

2012-12-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added the test that the file was actually closed using external file (as in test_close()). -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue16486] Add context manager support to aifc module

2012-12-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9beb11071dd1 by Serhiy Storchaka in branch 'default': Issue #16486: Make aifc files work with 'with' as context managers. http://hg.python.org/cpython/rev/9beb11071dd1 -- nosy: +python-dev ___ Python trac

[issue16486] Add context manager support to aifc module

2012-12-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: fout.close() here is intentional no-op. This is a check that fout was closed properly (in contrary case close() should raise exception). Unfortunately there is no other way to test that fout was closed. -- ___ Pyt

[issue16486] Add context manager support to aifc module

2012-12-27 Thread Georg Brandl
Georg Brandl added the comment: The "self.fout.close()" is not needed here I think. Another thing the test should test is that the file was actually closed on exception. Otherwise, LGTM. -- nosy: +georg.brandl ___ Python tracker

[issue16486] Add context manager support to aifc module

2012-12-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16486] Add context manager support to aifc module

2012-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +FD leaks in aifc module nosy: +r.david.murray stage: -> patch review ___ Python tracker ___ _

[issue16486] Add context manager support to aifc module

2012-11-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch adds context manager support aifc module. Now objects returned by aifc.open() will support context manager protocol. This issue required first fixing issue16485 to pass tests. -- components: Library (Lib) files: aifc_context_man