Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16650
___
___
Python-bugs-list
Terry J. Reedy added the comment:
sorry for noise
--
nosy: +terry.reedy
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16650
___
Roundup Robot added the comment:
New changeset 0cc4fe5634cf by Andrew Svetlov in branch '3.2':
Keep ref to ECHILD in local scope (#16650)
http://hg.python.org/cpython/rev/0cc4fe5634cf
New changeset 0b1a49f99169 by Andrew Svetlov in branch '3.3':
Keep ref to ECHILD in local scope (#16650)
Andrew Svetlov added the comment:
Close the issue.
For future improvements (like ChildProcessError using) please open new one.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Andrew Svetlov added the comment:
As I can see in Py_Finalize finalized for standard exception classes is called
after any python code has been finished, so we don't need to protect those
exceptions.
--
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16650
___
___
Python-bugs-list mailing list
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16650
___
___
Python-bugs-list
Andrew Svetlov added the comment:
The patch LGTM.
About _handle_exitstatus: I guess nothing wrong to fix it also.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16650
___
Serhiy Storchaka added the comment:
I'm just asking if this is a bug. If using building exceptions is safe, then we
can get rid of _os_error and _ECHILD in 3.3+, using OSError and
ChildProcessError instead.
--
___
Python tracker
Gregory P. Smith added the comment:
it's a potential bug. your patch looks good.
as for _handle_exitstatus referring to SubprocessError, that is fine. In that
situation it is trying to raise the exception and the only time that would ever
be a problem is when called by the gc during a
New submission from Serhiy Storchaka:
As noted in Popen._internal_poll() docstring this method cannot reference
anything outside of the local scope. However it references errno.ECHILD. The
proposed patch fixes this.
Is it good that Popen._handle_exitstatus() references building
11 matches
Mail list logo