[issue16685] Deprecate accepting strings as arguments in audioop functions
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +easy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
New submission from Serhiy Storchaka: Inadvertently strings accepted as arguments of audioop functions. This is a meaningless behavior and remnant of Python 2. We should drop string support. -- components: Extension Modules messages: 177477 nosy: serhiy.storchaka priority: normal severity: normal stage: needs patch status: open title: Deprecate accepting strings as arguments in audioop functions type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Ezio Melotti added the comment: What happens if you pass strings? If it doesn't work we can just fix it to raise an exception and stop returning random results, if it works but bytes should be used instead, we should go through a deprecation process. -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Serhiy Storchaka added the comment:
What happens if you pass strings?
They are encoded with UTF-8. See 's#' and 's*' formats in PyArg_ParseTuple()
('y*' recommended for bytes).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16685
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
STINNER Victor added the comment: Accepting Unicode strings is surprising and must fail. I don't think that a deprecation process is required here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Serhiy Storchaka added the comment: Accepting Unicode strings is surprising and must fail. I don't think that a deprecation process is required here. Should it be fixed in 3.4 only or in all 3.x? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Ezio Melotti added the comment: The deprecation process can be avoided only if passing strings results in a meaningless result. If there are cases where users are passing strings and everything works fine -- even if they should be passing bytes instead -- we should deprecate strings first to warn the users that the feature is going to be removed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
Serhiy Storchaka added the comment: In 2.x it was have a little sense (if you use some 8-bit encoding as default encoding, but the default was 7-bit ascii). But with utf-8 it doesn't have sense and should quickly lead to an unexpected result (or just fail in most cases). -- dependencies: +Document that audioop works with bytes, not strings ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16685] Deprecate accepting strings as arguments in audioop functions
STINNER Victor added the comment: Should it be fixed in 3.4 only or in all 3.x? Such change cannot be done in a minor release (like 3.3.x), so it can only be done in Python 3.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16685 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
